From a18073230b9be64f9d9e0ed52b4351b704b892c1 Mon Sep 17 00:00:00 2001 From: Andreas Stenius Date: Sat, 6 Jul 2024 08:08:00 +0200 Subject: [PATCH 1/3] refactor used actions into table. --- .../generate_github_workflows.py | 53 ++++++++++++------- 1 file changed, 35 insertions(+), 18 deletions(-) diff --git a/src/python/pants_release/generate_github_workflows.py b/src/python/pants_release/generate_github_workflows.py index 587cf91fdaf..b7ca346ee8f 100644 --- a/src/python/pants_release/generate_github_workflows.py +++ b/src/python/pants_release/generate_github_workflows.py @@ -19,6 +19,23 @@ from pants.util.strutil import softwrap +ACTION = { + "action-send-mail": "dawidd6/action-send-mail@v3.8.0", + "cache": "actions/cache@v3", + "checkout": "actions/checkout@v3", + "download-artifact": "actions/download-artifact@v3", + "expose-pythons": "pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe", + "github-action-required-labels": "mheap/github-action-required-labels@v4.0.0", + "rust-cache": "benjyw/rust-cache@461b9f8eee66b575bce78977bf649b8b7a8d53f1", + "setup-go": "actions/setup-go@v3", + "setup-java": "actions/setup-java@v3", + "setup-node": "actions/setup-node@v3", + "setup-protoc": "arduino/setup-protoc@9b1ee5b22b0a3f1feb8c2ff99b32c89b3c3191e9", + "setup-python": "actions/setup-python@v4", + "slack-github-action": "slackapi/slack-github-action@v1.24.0", + "upload-artifact": "actions/upload-artifact@v3", +} + HEADER = dedent( """\ # GENERATED, DO NOT EDIT! @@ -153,7 +170,7 @@ def ensure_category_label() -> Sequence[Step]: { "if": "github.event_name == 'pull_request'", "name": "Ensure category label", - "uses": "mheap/github-action-required-labels@v4.0.0", + "uses": ACTION["github-action-required-labels"], "env": {"GITHUB_TOKEN": gha_expr("secrets.GITHUB_TOKEN")}, "with": { "mode": "exactly", @@ -180,7 +197,7 @@ def ensure_release_notes() -> Sequence[Step]: # out via a label. "if": "github.event_name == 'pull_request' && !needs.classify_changes.outputs.notes", "name": "Ensure appropriate label", - "uses": "mheap/github-action-required-labels@v4.0.0", + "uses": ACTION["github-action-required-labels"], "env": {"GITHUB_TOKEN": gha_expr("secrets.GITHUB_TOKEN")}, "with": { "mode": "minimum", @@ -220,7 +237,7 @@ def checkout( # We need to fetch a few commits back, to be able to access HEAD^2 in the PR case. { "name": "Check out code", - "uses": "actions/checkout@v3", + "uses": ACTION["checkout"], "with": { **fetch_depth_opt, **({"ref": ref} if ref else {}), @@ -322,7 +339,7 @@ def install_rustup() -> Step: def install_python(version: str) -> Step: return { "name": f"Set up Python {version}", - "uses": "actions/setup-python@v4", + "uses": ACTION["setup-python"], "with": {"python-version": version}, } @@ -330,7 +347,7 @@ def install_python(version: str) -> Step: def install_node(version: str) -> Step: return { "name": f"Set up Node {version}", - "uses": "actions/setup-node@v3", + "uses": ACTION["setup-node"], "with": {"node-version": version}, } @@ -338,7 +355,7 @@ def install_node(version: str) -> Step: def install_jdk() -> Step: return { "name": "Install AdoptJDK", - "uses": "actions/setup-java@v3", + "uses": ACTION["setup-java"], "with": { "distribution": "adopt", "java-version": "11", @@ -349,7 +366,7 @@ def install_jdk() -> Step: def install_go() -> Step: return { "name": "Install Go", - "uses": "actions/setup-go@v3", + "uses": ACTION["setup-go"], "with": {"go-version": "1.19.5"}, } @@ -360,7 +377,7 @@ def install_go() -> Step: def install_protoc() -> Step: return { "name": "Install Protoc", - "uses": "arduino/setup-protoc@9b1ee5b22b0a3f1feb8c2ff99b32c89b3c3191e9", + "uses": ACTION["setup-protoc"], "with": { "version": "23.x", "repo-token": "${{ secrets.GITHUB_TOKEN }}", @@ -453,7 +470,7 @@ def wrap_cmd(self, cmd: str) -> str: def native_binaries_upload(self) -> Step: return { "name": "Upload native binaries", - "uses": "actions/upload-artifact@v3", + "uses": ACTION["upload-artifact"], "with": { "name": f"native_binaries.{gha_expr('matrix.python-version')}.{self.platform_name()}", "path": "\n".join(NATIVE_FILES), @@ -464,7 +481,7 @@ def native_binaries_download(self) -> Sequence[Step]: return [ { "name": "Download native binaries", - "uses": "actions/download-artifact@v3", + "uses": ACTION["download-artifact"], "with": { "name": f"native_binaries.{gha_expr('matrix.python-version')}.{self.platform_name()}", "path": NATIVE_FILES_COMMON_PREFIX, @@ -485,7 +502,7 @@ def rust_caches(self) -> Sequence[Step]: }, { "name": "Cache Rust toolchain", - "uses": "actions/cache@v3", + "uses": ACTION["cache"], "with": { "path": f"~/.rustup/toolchains/{rust_channel()}-*\n~/.rustup/update-hashes\n~/.rustup/settings.toml\n", "key": f"{self.platform_name()}-rustup-{hash_files('src/rust/engine/rust-toolchain')}-v2", @@ -493,7 +510,7 @@ def rust_caches(self) -> Sequence[Step]: }, { "name": "Cache Cargo", - "uses": "benjyw/rust-cache@461b9f8eee66b575bce78977bf649b8b7a8d53f1", + "uses": ACTION["rust-cache"], "with": { # If set, replaces the job id in the cache key, so that the cache is stable across jobs. # If we don't set this, each job may restore from a previous job's cache entry (via a @@ -523,7 +540,7 @@ def bootstrap_caches(self) -> Sequence[Step]: }, { "name": "Cache native engine", - "uses": "actions/cache@v3", + "uses": ACTION["cache"], "with": { "path": "\n".join(NATIVE_FILES), "key": f"{self.platform_name()}-engine-{gha_expr('steps.get-engine-hash.outputs.hash')}-v1", @@ -547,7 +564,7 @@ def expose_all_pythons(self) -> Sequence[Step]: ret.append( { "name": "Expose Pythons", - "uses": "pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe", + "uses": ACTION["expose-pythons"], } ) return ret @@ -584,7 +601,7 @@ def bootstrap_pants(self) -> Sequence[Step]: def upload_log_artifacts(self, name: str) -> Step: return { "name": "Upload pants.log", - "uses": "actions/upload-artifact@v3", + "uses": ACTION["upload-artifact"], "if": "always()", "continue-on-error": True, "with": { @@ -1218,7 +1235,7 @@ def release_jobs_and_inputs() -> tuple[Jobs, dict[str, Any]]: "steps": [ { "name": "Checkout Pants at Release Tag", - "uses": "actions/checkout@v3", + "uses": ACTION["checkout"], "with": { # N.B.: We need the last few edits to VERSION. Instead of guessing, just # clone the repo, we're not so big as to need to optimize this. @@ -1241,7 +1258,7 @@ def release_jobs_and_inputs() -> tuple[Jobs, dict[str, Any]]: }, { "name": "Announce to Slack", - "uses": "slackapi/slack-github-action@v1.24.0", + "uses": ACTION["slack-github-action"], "with": { "channel-id": "C18RRR4JK", "payload-file-path": "${{ runner.temp }}/slack_announcement.json", @@ -1250,7 +1267,7 @@ def release_jobs_and_inputs() -> tuple[Jobs, dict[str, Any]]: }, { "name": "Announce to pants-devel", - "uses": "dawidd6/action-send-mail@v3.8.0", + "uses": ACTION["action-send-mail"], "with": { # Note: Email is sent from the dedicated account pants.announce@gmail.com. # The EMAIL_CONNECTION_URL should be of the form: From 32bf00b589c0e32782fe5bef9b424e575248d81f Mon Sep 17 00:00:00 2001 From: Andreas Stenius Date: Sat, 6 Jul 2024 08:09:40 +0200 Subject: [PATCH 2/3] bump actions/cache, actions/checkout, actions/setup-go, actions/setup-java, actions/setup-node, and actions/setup-python. --- .github/workflows/audit.yaml | 2 +- .github/workflows/cache_comparison.yaml | 4 +- .github/workflows/public_repos.yaml | 88 ++++++------ .github/workflows/release.yaml | 26 ++-- .github/workflows/test.yaml | 136 +++++++++--------- .../generate_github_workflows.py | 12 +- 6 files changed, 134 insertions(+), 134 deletions(-) diff --git a/.github/workflows/audit.yaml b/.github/workflows/audit.yaml index 41d7d01e692..9196ec14c7b 100644 --- a/.github/workflows/audit.yaml +++ b/.github/workflows/audit.yaml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - name: Cargo audit (for security vulnerabilities) diff --git a/.github/workflows/cache_comparison.yaml b/.github/workflows/cache_comparison.yaml index b50ed1eaee0..c99bb47cf71 100644 --- a/.github/workflows/cache_comparison.yaml +++ b/.github/workflows/cache_comparison.yaml @@ -8,11 +8,11 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons diff --git a/.github/workflows/public_repos.yaml b/.github/workflows/public_repos.yaml index 904046869e6..23b40f34532 100644 --- a/.github/workflows/public_repos.yaml +++ b/.github/workflows/public_repos.yaml @@ -13,12 +13,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: AlexTereshenkov/cheeseshop-query - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Pants on @@ -98,12 +98,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: Ars-Linguistica/mlconjug3 - name: Set up Python 3.10 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.10' - name: Pants on @@ -150,12 +150,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: OpenSaMD/OpenSaMD - name: Set up Python 3.9.15 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: 3.9.15 - name: Pants on @@ -235,13 +235,13 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: StackStorm/st2 submodules: recursive - name: Set up Python 3.8 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.8' - name: Pants on @@ -333,12 +333,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: fucina/treb - name: Set up Python 3.10 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.10' - name: Pants on @@ -405,12 +405,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: ghandic/jsf - name: Set up Python 3.10 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.10' - name: Pants on @@ -467,12 +467,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: komprenilo/liga - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Pants on @@ -519,12 +519,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: lablup/backend.ai - name: Set up Python 3.11.4 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: 3.11.4 - name: Pants on @@ -609,12 +609,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: mitodl/ol-django - name: Set up Python 3.10 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.10' - name: Pants on @@ -663,12 +663,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: mitodl/ol-infrastructure - name: Set up Python 3.10 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.10' - name: Pants on @@ -715,12 +715,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: naccdata/flywheel-gear-extensions - name: Set up Python 3.10 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.10' - name: Pants on @@ -778,16 +778,16 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: pantsbuild/example-adhoc - name: Set up Python 3.10 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.10' - name: Set up Node 20 - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: '20' - name: Pants on @@ -844,12 +844,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: pantsbuild/example-codegen - name: Set up Python 3.10 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.10' - if: runner.os == 'Linux' @@ -941,12 +941,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: pantsbuild/example-django - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Pants on @@ -1027,12 +1027,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: pantsbuild/example-docker - name: Set up Python 3.8 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.8' - name: Pants on @@ -1112,16 +1112,16 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: pantsbuild/example-golang - name: Set up Python 3.10 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.10' - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - name: Pants on @@ -1201,12 +1201,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: pantsbuild/example-jvm - name: Set up Python 3.10 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.10' - name: Pants on @@ -1286,12 +1286,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: pantsbuild/example-kotlin - name: Set up Python 3.10 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.10' - name: Pants on @@ -1371,12 +1371,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: pantsbuild/example-python - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Pants on @@ -1456,12 +1456,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: pantsbuild/example-visibility - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Pants on @@ -1531,12 +1531,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 repository: pantsbuild/scie-pants - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Pants on diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 5caba39051b..e6e2a43a238 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -20,7 +20,7 @@ jobs: - ARM64 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 ref: ${{ needs.release_info.outputs.build-ref }} @@ -93,7 +93,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 ref: ${{ needs.release_info.outputs.build-ref }} @@ -120,7 +120,7 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} version: 23.x - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - env: @@ -176,7 +176,7 @@ jobs: - macOS-10.15-X64 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 ref: ${{ needs.release_info.outputs.build-ref }} @@ -188,7 +188,7 @@ jobs: - name: Set rustup profile run: rustup set profile default - name: Cache Rust toolchain - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: macOS10-15-x86_64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2 @@ -211,7 +211,7 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} version: 23.x - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - env: @@ -260,7 +260,7 @@ jobs: - macOS-11-ARM64 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 ref: ${{ needs.release_info.outputs.build-ref }} @@ -272,7 +272,7 @@ jobs: - name: Set rustup profile run: rustup set profile default - name: Cache Rust toolchain - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: macOS11-ARM64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2 @@ -295,7 +295,7 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} version: 23.x - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - env: @@ -345,13 +345,13 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout Pants at Release Tag - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: '0' fetch-tags: true ref: ${{ needs.release_info.outputs.build-ref }} - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons @@ -364,7 +364,7 @@ jobs: - name: Set rustup profile run: rustup set profile default - name: Cache Rust toolchain - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: Linux-x86_64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2 path: '~/.rustup/toolchains/1.79.0-* @@ -385,7 +385,7 @@ jobs: run: echo "hash=$(./build-support/bin/rust/print_engine_hash.sh)" >> $GITHUB_OUTPUT shell: bash - name: Cache native engine - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: Linux-x86_64-engine-${{ steps.get-engine-hash.outputs.hash }}-v1 path: 'src/python/pants/bin/native_client diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 6b16b5184bf..f39ba053c6a 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -24,7 +24,7 @@ jobs: - ARM64 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - name: Install Protoc @@ -35,7 +35,7 @@ jobs: - name: Set rustup profile run: rustup set profile default - name: Cache Rust toolchain - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: Linux-ARM64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2 path: '~/.rustup/toolchains/1.79.0-* @@ -56,7 +56,7 @@ jobs: run: echo "hash=$(./build-support/bin/rust/print_engine_hash.sh)" >> $GITHUB_OUTPUT shell: bash - name: Cache native engine - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: Linux-ARM64-engine-${{ steps.get-engine-hash.outputs.hash }}-v1 path: 'src/python/pants/bin/native_client @@ -112,11 +112,11 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Install Protoc @@ -127,7 +127,7 @@ jobs: - name: Set rustup profile run: rustup set profile default - name: Cache Rust toolchain - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: Linux-x86_64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2 path: '~/.rustup/toolchains/1.79.0-* @@ -148,7 +148,7 @@ jobs: run: echo "hash=$(./build-support/bin/rust/print_engine_hash.sh)" >> $GITHUB_OUTPUT shell: bash - name: Cache native engine - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: Linux-x86_64-engine-${{ steps.get-engine-hash.outputs.hash }}-v1 path: 'src/python/pants/bin/native_client @@ -214,11 +214,11 @@ jobs: - macos-12 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Install Protoc @@ -229,7 +229,7 @@ jobs: - name: Set rustup profile run: rustup set profile default - name: Cache Rust toolchain - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: macOS12-x86_64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2 path: '~/.rustup/toolchains/1.79.0-* @@ -250,7 +250,7 @@ jobs: run: echo "hash=$(./build-support/bin/rust/print_engine_hash.sh)" >> $GITHUB_OUTPUT shell: bash - name: Cache native engine - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: macOS12-x86_64-engine-${{ steps.get-engine-hash.outputs.hash }}-v1 path: 'src/python/pants/bin/native_client @@ -312,7 +312,7 @@ jobs: - ARM64 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - name: Configure Git @@ -368,7 +368,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - name: Configure Git @@ -393,7 +393,7 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} version: 23.x - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - env: @@ -427,7 +427,7 @@ jobs: - macOS-10.15-X64 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - name: Install Protoc @@ -438,7 +438,7 @@ jobs: - name: Set rustup profile run: rustup set profile default - name: Cache Rust toolchain - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: macOS10-15-x86_64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2 path: '~/.rustup/toolchains/1.79.0-* @@ -460,7 +460,7 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} version: 23.x - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - env: @@ -494,7 +494,7 @@ jobs: - macOS-11-ARM64 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - name: Install Protoc @@ -505,7 +505,7 @@ jobs: - name: Set rustup profile run: rustup set profile default - name: Cache Rust toolchain - uses: actions/cache@v3 + uses: actions/cache@v4 with: key: macOS11-ARM64-rustup-${{ hashFiles('src/rust/engine/rust-toolchain') }}-v2 path: '~/.rustup/toolchains/1.79.0-* @@ -527,7 +527,7 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} version: 23.x - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - env: @@ -598,7 +598,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - id: classify @@ -620,7 +620,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - env: @@ -642,7 +642,7 @@ jobs: \ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\ \n" - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Download native binaries @@ -725,11 +725,11 @@ jobs: - ARM64 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' @@ -777,7 +777,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - env: @@ -799,12 +799,12 @@ jobs: \ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\ \n" - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - if: runner.os == 'Linux' @@ -819,7 +819,7 @@ jobs: ' - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons @@ -868,7 +868,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - env: @@ -890,12 +890,12 @@ jobs: \ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\ \n" - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - if: runner.os == 'Linux' @@ -910,7 +910,7 @@ jobs: ' - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons @@ -959,7 +959,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - env: @@ -981,12 +981,12 @@ jobs: \ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\ \n" - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - if: runner.os == 'Linux' @@ -1001,7 +1001,7 @@ jobs: ' - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons @@ -1050,7 +1050,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - env: @@ -1072,12 +1072,12 @@ jobs: \ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\ \n" - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - if: runner.os == 'Linux' @@ -1092,7 +1092,7 @@ jobs: ' - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons @@ -1141,7 +1141,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - env: @@ -1163,12 +1163,12 @@ jobs: \ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\ \n" - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - if: runner.os == 'Linux' @@ -1183,7 +1183,7 @@ jobs: ' - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons @@ -1232,7 +1232,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - env: @@ -1254,12 +1254,12 @@ jobs: \ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\ \n" - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - if: runner.os == 'Linux' @@ -1274,7 +1274,7 @@ jobs: ' - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons @@ -1323,7 +1323,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - env: @@ -1345,12 +1345,12 @@ jobs: \ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\ \n" - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - if: runner.os == 'Linux' @@ -1365,7 +1365,7 @@ jobs: ' - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons @@ -1414,7 +1414,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - env: @@ -1436,12 +1436,12 @@ jobs: \ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\ \n" - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - if: runner.os == 'Linux' @@ -1456,7 +1456,7 @@ jobs: ' - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons @@ -1505,7 +1505,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - env: @@ -1527,12 +1527,12 @@ jobs: \ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\ \n" - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - if: runner.os == 'Linux' @@ -1547,7 +1547,7 @@ jobs: ' - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons @@ -1596,7 +1596,7 @@ jobs: - ubuntu-20.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - env: @@ -1618,12 +1618,12 @@ jobs: \ \"PANTS_REMOTE_CACHE_READ=true\" >> \"$GITHUB_ENV\"\necho \"PANTS_REMOTE_CACHE_WRITE=${CACHE_WRITE}\" >> \"$GITHUB_ENV\"\ \n" - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' - name: Install Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version: 1.19.5 - if: runner.os == 'Linux' @@ -1638,7 +1638,7 @@ jobs: ' - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons @@ -1687,16 +1687,16 @@ jobs: - macos-12 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 10 - name: Install AdoptJDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: adopt java-version: '11' - name: Set up Python 3.9 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: '3.9' - name: Expose Pythons diff --git a/src/python/pants_release/generate_github_workflows.py b/src/python/pants_release/generate_github_workflows.py index b7ca346ee8f..7762a5b5613 100644 --- a/src/python/pants_release/generate_github_workflows.py +++ b/src/python/pants_release/generate_github_workflows.py @@ -21,17 +21,17 @@ ACTION = { "action-send-mail": "dawidd6/action-send-mail@v3.8.0", - "cache": "actions/cache@v3", - "checkout": "actions/checkout@v3", + "cache": "actions/cache@v4", + "checkout": "actions/checkout@v4", "download-artifact": "actions/download-artifact@v3", "expose-pythons": "pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe", "github-action-required-labels": "mheap/github-action-required-labels@v4.0.0", "rust-cache": "benjyw/rust-cache@461b9f8eee66b575bce78977bf649b8b7a8d53f1", - "setup-go": "actions/setup-go@v3", - "setup-java": "actions/setup-java@v3", - "setup-node": "actions/setup-node@v3", + "setup-go": "actions/setup-go@v5", + "setup-java": "actions/setup-java@v4", + "setup-node": "actions/setup-node@v4", "setup-protoc": "arduino/setup-protoc@9b1ee5b22b0a3f1feb8c2ff99b32c89b3c3191e9", - "setup-python": "actions/setup-python@v4", + "setup-python": "actions/setup-python@v5", "slack-github-action": "slackapi/slack-github-action@v1.24.0", "upload-artifact": "actions/upload-artifact@v3", } From 9d77334027d723e8fe38e64858dc8ea0f274c1a4 Mon Sep 17 00:00:00 2001 From: Andreas Stenius Date: Sat, 6 Jul 2024 08:27:30 +0200 Subject: [PATCH 3/3] Bump upload-artifacts, and download-artifacts for node20. This is a potentially breaking change. See https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md --- .github/workflows/release.yaml | 12 ++- .github/workflows/test.yaml | 92 +++++++++++-------- .../generate_github_workflows.py | 5 +- 3 files changed, 67 insertions(+), 42 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index e6e2a43a238..4c4758933b9 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -57,9 +57,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-wheels-and-pex-Linux-ARM64 + overwrite: 'true' path: .pants.d/workdir/*.log - if: needs.release_info.outputs.is-release == 'true' name: Upload Wheel and Pex @@ -134,9 +135,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-wheels-and-pex-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log - if: needs.release_info.outputs.is-release == 'true' name: Upload Wheel and Pex @@ -225,9 +227,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-wheels-and-pex-macOS10-15-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log - if: needs.release_info.outputs.is-release == 'true' name: Upload Wheel and Pex @@ -309,9 +312,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-wheels-and-pex-macOS11-ARM64 + overwrite: 'true' path: .pants.d/workdir/*.log - if: needs.release_info.outputs.is-release == 'true' name: Upload Wheel and Pex diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index f39ba053c6a..bee10997f62 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -81,12 +81,13 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-bootstrap-Linux-ARM64 + overwrite: 'true' path: .pants.d/workdir/*.log - name: Upload native binaries - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-ARM64 path: 'src/python/pants/bin/native_client @@ -173,12 +174,13 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-bootstrap-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log - name: Upload native binaries - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: 'src/python/pants/bin/native_client @@ -275,12 +277,13 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-bootstrap-macOS12-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log - name: Upload native binaries - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.macOS12-x86_64 path: 'src/python/pants/bin/native_client @@ -347,9 +350,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-wheels-and-pex-Linux-ARM64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 build_wheels_linux_x86_64: @@ -407,9 +411,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-wheels-and-pex-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 build_wheels_macos10_15_x86_64: @@ -474,9 +479,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-wheels-and-pex-macOS10-15-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 build_wheels_macos11_arm64: @@ -541,9 +547,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-wheels-and-pex-macOS11-ARM64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 check_labels: @@ -646,7 +653,7 @@ jobs: with: python-version: '3.9' - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: src/python/pants @@ -659,9 +666,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-lint-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 30 merge_ok: @@ -734,7 +742,7 @@ jobs: distribution: adopt java-version: '11' - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-ARM64 path: src/python/pants @@ -760,9 +768,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-Linux-ARM64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 test_python_linux_x86_64_0: @@ -825,7 +834,7 @@ jobs: - name: Expose Pythons uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: src/python/pants @@ -851,9 +860,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-0_10-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 test_python_linux_x86_64_1: @@ -916,7 +926,7 @@ jobs: - name: Expose Pythons uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: src/python/pants @@ -942,9 +952,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-1_10-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 test_python_linux_x86_64_2: @@ -1007,7 +1018,7 @@ jobs: - name: Expose Pythons uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: src/python/pants @@ -1033,9 +1044,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-2_10-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 test_python_linux_x86_64_3: @@ -1098,7 +1110,7 @@ jobs: - name: Expose Pythons uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: src/python/pants @@ -1124,9 +1136,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-3_10-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 test_python_linux_x86_64_4: @@ -1189,7 +1202,7 @@ jobs: - name: Expose Pythons uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: src/python/pants @@ -1215,9 +1228,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-4_10-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 test_python_linux_x86_64_5: @@ -1280,7 +1294,7 @@ jobs: - name: Expose Pythons uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: src/python/pants @@ -1306,9 +1320,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-5_10-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 test_python_linux_x86_64_6: @@ -1371,7 +1386,7 @@ jobs: - name: Expose Pythons uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: src/python/pants @@ -1397,9 +1412,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-6_10-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 test_python_linux_x86_64_7: @@ -1462,7 +1478,7 @@ jobs: - name: Expose Pythons uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: src/python/pants @@ -1488,9 +1504,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-7_10-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 test_python_linux_x86_64_8: @@ -1553,7 +1570,7 @@ jobs: - name: Expose Pythons uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: src/python/pants @@ -1579,9 +1596,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-8_10-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 test_python_linux_x86_64_9: @@ -1644,7 +1662,7 @@ jobs: - name: Expose Pythons uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.Linux-x86_64 path: src/python/pants @@ -1670,9 +1688,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-9_10-Linux-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 test_python_macos12_x86_64: @@ -1702,7 +1721,7 @@ jobs: - name: Expose Pythons uses: pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe - name: Download native binaries - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: native_binaries.${{ matrix.python-version }}.macOS12-x86_64 path: src/python/pants @@ -1728,9 +1747,10 @@ jobs: - continue-on-error: true if: always() name: Upload pants.log - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: logs-python-test-macOS12-x86_64 + overwrite: 'true' path: .pants.d/workdir/*.log timeout-minutes: 90 name: Pull Request CI diff --git a/src/python/pants_release/generate_github_workflows.py b/src/python/pants_release/generate_github_workflows.py index 7762a5b5613..b804c9828da 100644 --- a/src/python/pants_release/generate_github_workflows.py +++ b/src/python/pants_release/generate_github_workflows.py @@ -23,7 +23,7 @@ "action-send-mail": "dawidd6/action-send-mail@v3.8.0", "cache": "actions/cache@v4", "checkout": "actions/checkout@v4", - "download-artifact": "actions/download-artifact@v3", + "download-artifact": "actions/download-artifact@v4", "expose-pythons": "pantsbuild/actions/expose-pythons@627a8ce25d972afa03da1641be9261bbbe0e3ffe", "github-action-required-labels": "mheap/github-action-required-labels@v4.0.0", "rust-cache": "benjyw/rust-cache@461b9f8eee66b575bce78977bf649b8b7a8d53f1", @@ -33,7 +33,7 @@ "setup-protoc": "arduino/setup-protoc@9b1ee5b22b0a3f1feb8c2ff99b32c89b3c3191e9", "setup-python": "actions/setup-python@v5", "slack-github-action": "slackapi/slack-github-action@v1.24.0", - "upload-artifact": "actions/upload-artifact@v3", + "upload-artifact": "actions/upload-artifact@v4", } HEADER = dedent( @@ -607,6 +607,7 @@ def upload_log_artifacts(self, name: str) -> Step: "with": { "name": f"logs-{name.replace('/', '_')}-{self.platform_name()}", "path": ".pants.d/workdir/*.log", + "overwrite": "true", }, }