-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Make API reference intro section concise #19846
Conversation
revise the typo "in not guaranteed" to "is not guaranteed"
``pandas.io`` and ``pandas.tseries`` submodules are public as well (those | ||
mentioned in the documentation). Further, the ``pandas.api.types`` subpackage | ||
holds some public functions related to data types in pandas. | ||
Some subpackages are public which include ``pandas.errors``, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these all could be references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jreback , sorry, I don't understand your comment. Could you clarify what are the further changes that I need to address for this commit? Thanks a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use :module:`pandas.errors`
and so on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just uploaded a new fix. Please let me know if I am still doing it wrong. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback we don't have module docstring pages, so I don't think such links will work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jorisvandenbossche , thanks for the clarification. Just revert the commit back to origin: dccfee5
Codecov Report
@@ Coverage Diff @@
## master #19846 +/- ##
==========================================
+ Coverage 91.66% 91.68% +0.01%
==========================================
Files 150 150
Lines 48938 48915 -23
==========================================
- Hits 44860 44847 -13
+ Misses 4078 4068 -10
Continue to review full report at Codecov.
|
Thanks! |
Also revise the typo "in not guaranteed" to "is not guaranteed"