You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
See for example the rolling.sum docs. These args and kwargs are not used for the computation. If any args are passed, these ops will raise. If the kwargs axis, dtype, or out is passed, they will also raise. Any other kwargs are ignored.
This was done to produce warning messages if one tries to use e.g. np.sum with a Window object. (ref: #12811, #12644)
r = Series(np.random.randn(100)).rolling(2)
np.sum(r)
# pandas.errors.UnsupportedFunctionCall: numpy operations are not valid with window objects. Use .rolling(...).sum() instead
If we are to remove these args / kwargs, the error message would instead be TypeError: sum() got an unexpected keyword argument 'axis'. While this error message may be more confusing to the user, I do not think we should be adding args / kwargs to our API to defend against a user trying to use pandas objects with NumPy functions.
Any functions where args and kwargs are used (e.g. apply) will not be deprecated.
See for example the rolling.sum docs. These args and kwargs are not used for the computation. If any args are passed, these ops will raise. If the kwargs
axis
,dtype
, orout
is passed, they will also raise. Any other kwargs are ignored.This was done to produce warning messages if one tries to use e.g.
np.sum
with a Window object. (ref: #12811, #12644)If we are to remove these args / kwargs, the error message would instead be
TypeError: sum() got an unexpected keyword argument 'axis'
. While this error message may be more confusing to the user, I do not think we should be adding args / kwargs to our API to defend against a user trying to use pandas objects with NumPy functions.Any functions where args and kwargs are used (e.g. apply) will not be deprecated.
cc @jreback @jorisvandenbossche @mroeschke for any thoughts.
The text was updated successfully, but these errors were encountered: