Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecate _data when getting BlockManager #33333

Closed
jreback opened this issue Apr 6, 2020 · 2 comments · Fixed by #52003
Closed

DEPR: deprecate _data when getting BlockManager #33333

jreback opened this issue Apr 6, 2020 · 2 comments · Fixed by #52003
Labels
Deprecate Functionality to remove in pandas Internals Related to non-user accessible pandas implementation Needs Discussion Requires discussion from core team before further action

Comments

@jreback
Copy link
Contributor

jreback commented Apr 6, 2020

we renamed _data -> _mgr to provide more clarity on the internals; we should add a DeprecationWarning on calling this from the pandas objects (DataFrame/Series) to have downstream update to use _mgr at some point: #33054 (comment)

@jreback jreback added Deprecate Functionality to remove in pandas Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 6, 2020
@jreback jreback added this to the Contributions Welcome milestone Apr 6, 2020
@mroeschke mroeschke removed the Needs Triage Issue that has not been reviewed by a pandas team member label Apr 6, 2020
@jorisvandenbossche jorisvandenbossche removed this from the Contributions Welcome milestone Apr 7, 2020
@jorisvandenbossche jorisvandenbossche added the Needs Discussion Requires discussion from core team before further action label Apr 7, 2020
@jorisvandenbossche
Copy link
Member

I personally don't think there is much value in going through a deprecation cycle here.

We only did this rename to make searching in our code base easier, and not because something is broken or it is a wrong name or something else we are trying to solve, I don't see a reason why we should bother ourselves and downstream packages with a deprecation cycle since it is not "fixing" anything.

If we wanted to discourage the use of accessing the BlockManager (and at the same time while renaming it would, stipulate that the new name _mgr is really private now and shouldn't be accessed), that's something else. But right now we are not changing anything but the name (eg we don't provide an alternative API to get the blocks). So downstream packages, who might have legitimate use cases for getting the blocks, would just add some compatibility code to use the old/new name depending on the version, complicating their code for not much reason?

@jbrockmendel
Copy link
Member

We did the renaming to make it easier to identify places where we access the BlockManager, but without a deprecation warning it will be easy for uses of ._data to sneak back in.

w/r/t downstream projects, I think we do want to wean most of them off of accessing the BlockManager.

@mroeschke mroeschke added the Internals Related to non-user accessible pandas implementation label Jul 31, 2021
@jbrockmendel jbrockmendel mentioned this issue Mar 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Internals Related to non-user accessible pandas implementation Needs Discussion Requires discussion from core team before further action
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants