Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ruby-standalone 1.8.0 and move pact details from the POST /pact call to the command line #105

Closed
3 of 5 tasks
bethesque opened this issue Oct 4, 2017 · 4 comments

Comments

@bethesque
Copy link
Member

bethesque commented Oct 4, 2017

Instead of posting the consumer name, provider name, and pact file write mode in the POST /pact call here https://github.com/pact-foundation/pact-js/blob/master/src/dsl/mockService.js#L75, they should now be passed in to the command line service call using --consumer, --provider and --pact-file-write-mode

TODO:

  • Ensure pact-node is capable of accepting these fields (update: it needs pact-file-write-mode)
  • Add any missing parameters to pact to pass through to pact-node
  • Make fields as 'deprecated' in current API
  • Update Documentation / Release Notes
  • Decommission fields in current API and publish new major version
@mefellows
Copy link
Member

Will need to raise this in the upstream pact-node repo as this is where the interaction with the CLI happens.

That being said, I believe we already do that - these fields are (or should/will be) optional - and perhaps we can deprecate them in the next major release.

@mefellows
Copy link
Member

Just checked pact-node, it's just missing the pact-file-write-mode

@bethesque
Copy link
Member Author

The consumer name/provider name are still mandatory. It's just that they should be provided in the start up command rather than in the POST /pact.

@mefellows
Copy link
Member

cc: @mboudreau I assume this needs to go in pact-node?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants