Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename #31

Closed
NathanWalker opened this issue Dec 13, 2015 · 11 comments
Closed

Rename #31

NathanWalker opened this issue Dec 13, 2015 · 11 comments

Comments

@NathanWalker
Copy link

This looks like a great seed setup, thanks for the efforts!

To avoid confusion in the community, could you please rename to something else?
Minko has had angular2-seed for quite a while before this. (https://github.com/mgechev/angular2-seed)

This is a great option though and renaming would help.

@PatrickJS
Copy link

👍

@PatrickJS
Copy link

tbh both repos are conflicting with angular's official seed https://github.com/angular/angular2-seed

@NathanWalker
Copy link
Author

@gdi2290 oh wow! I didn't even know about that 3rd one. Looks like we should have a name-off ;)
First one to change the name wins. 👍

@pablodenadai
Copy link
Owner

Hi all,

I find that having the projects called angular2-seed is actually a good thing for consistency. In the end of the day you are left with only a couple of terms that can describe your project - angular2, ng2, boilerplate, seed... - and it becomes a matter of taste.

This name pattern <framework>-seed is more widespread than we might think. I've done a quick search on GitHub's database and you can see them here:

Also, devs can easily see the owner's name and the project description for distinction.

So to wrap it up, I won't be changing the repo's name - at least not for now.

I hope my view wasn't too disappointing. :-)

@NathanWalker
Copy link
Author

@ghpabs I can appreciate your viewpoint. Reality is that having same name just creates practical problems not to mention user confusion when sifting through the array of information out there when coming to angular2.

Practical problem:

  • Dev wants to contribute to this seed and another seed called angular2-seed
  • They keep all angular2 repos in same folder on computer
  • When they clone it, it creates name collisions where git auto renames dups to have suffix -1, -2, etc.
  • Looking at the directory when trying to determine which is which is a face palm.

thanks.

@PatrickJS
Copy link

ya I have angular2-seed, angular2-seed-1, and angular2-seed-2

@maxime1992
Copy link
Collaborator

If you really want to clone the repo, in the same directory as another angular2-seed, just git clone https://github.com/ghpabs/angular2-seed.git angular2-seed-of-ghpabs. Besides, it's a seed so it's a start for your project and you should just rename it as you wish git clone https://github.com/ghpabs/angular2-seed.git my-super-angular2-project, don't you think ?

@NathanWalker
Copy link
Author

That makes sense for the savvy. Again, sadly though, it's not practical.
A lot of devs have literally hundreds of repo's they are contributing to and may forget their contributing directory may already have a repo named the same as yours, and alas, we are back to practicality and simplicity.

Your comment does not address:

not to mention user confusion when sifting through the array of information out there when coming to angular2

@NathanWalker
Copy link
Author

Your repo is very nice and should speak clearly to what it is.

The original here https://github.com/mgechev/angular2-seed is a true seed with no particular app setup in mind.

Yours is an implementation of a hero app.
angular2-hero-app-seed would not only help speak to the market about your repo, but also help newcomers to remember, oh yeah, that seed setup is closer to the type of app I'm trying to build because I remember that was the one like the hero app.

Just my 2 cents.

If your intent is to help the community with a solid seed. Naming is important and avoiding collisions with other repo's just helps that effort.

@pablodenadai
Copy link
Owner

I could go on here, but I don't have the energy for such discussion.

Repository owner locked and limited conversation to collaborators Dec 16, 2015
Repository owner unlocked this conversation Dec 16, 2015
@pablodenadai
Copy link
Owner

Here we go guys, add your suggestions to this issue #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants