Review comments.

Signed-off-by: fruffy <fruffy@nyu.edu>

Author: fruffy

backends/bmv2/portable_common/options.cpp

@@ -13,7 +13,7 @@ std::vector<const char *> *PortableOptions::process(int argc, char *const argv[]
         std::cerr << "Could not determine executable path" << std::endl;
         return nullptr;
     }
-    exe_name = cstring(executablePath.stem().c_str());
+    this->exe_name = cstring(executablePath.stem().c_str());
     searchForIncludePath(p4includePath,
                          {"p4include/bmv2"_cs, "../p4include/bmv2"_cs, "../../p4include/bmv2"_cs},
                          executablePath.c_str());

backends/dpdk/options.cpp

@@ -13,7 +13,7 @@ std::vector<const char *> *DpdkOptions::process(int argc, char *const argv[]) {
         std::cerr << "Could not determine executable path" << std::endl;
         return nullptr;
     }
-    exe_name = cstring(executablePath.stem().c_str());
+    this->exe_name = cstring(executablePath.stem().c_str());
 
     searchForIncludePath(p4includePath,
                          {"p4include/dpdk"_cs, "../p4include/dpdk"_cs, "../../p4include/dpdk"_cs},

backends/tofino/bf-p4c/bf-p4c-options.cpp

@@ -718,7 +718,7 @@ std::vector<const char *> *BFN_Options::process(int argc, char *const argv[]) {
         std::cerr << "Could not determine executable path" << std::endl;
         return nullptr;
     }
-    exe_name = cstring(executablePath.stem().c_str());
+    this->exe_name = cstring(executablePath.stem().c_str());
     // sde installs p4include directory to $SDE/install/share/p4c/p4include
     // and installs p4c to $SDE/install/bin/
     //

frontends/common/parser_options.cpp

@@ -377,7 +377,7 @@ std::vector<const char *> *ParserOptions::process(int argc, char *const argv[])
         std::cerr << "Could not determine executable path" << std::endl;
         return nullptr;
     }
-    exe_name = cstring(executablePath.stem().c_str());
+    this->exe_name = cstring(executablePath.stem().c_str());
 
     searchForIncludePath(p4_14includePath,
                          {"p4_14include"_cs, "../p4_14include"_cs, "../../p4_14include"_cs},

lib/alloc_trace.cpp

@@ -74,9 +74,11 @@ std::ostream &operator<<(std::ostream &out, const AllocTrace &at) {
     }
     std::sort(sorted.begin(), sorted.end(), [](auto &a, auto &b) { return a.first > b.first; });
 #if HAVE_LIBBACKTRACE
-    if (!global_backtrace_state)
+    if (!global_backtrace_state) {
+        // TODO: Do not use cstring here?
         global_backtrace_state =
-            backtrace_create_state(getExecutablePath().c_str(), 1, bt_error, &out);
+            backtrace_create_state(cstring(getExecutablePath().c_str()).c_str(), 1, bt_error, &out);
+    }
 #endif
 
     out << "Allocated a total of " << n4(total_total) << "B memory";

lib/exename.cpp

@@ -58,7 +58,6 @@ std::filesystem::path getExecutablePath(const std::filesystem::path &suggestedPa
     std::array<char, PATH_MAX> buffer{};
     uint32_t size = static_cast<uint32_t>(buffer.size());
     if (_NSGetExecutablePath(buffer.data(), &size) == 0) {
-        // TODO: What to do about the allocation here?
         return buffer.data();
     } else
 #elif defined(_WIN32)