clean up build warnings #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
force-pushed
the
warning-cleanup
branch
2 times, most recently
from
5e987c9 to
93166a5
Compare
davepacheco
force-pushed
the
warning-cleanup
branch
from
93166a5 to
b2a1f65
Compare
davepacheco
commented
Sep 15, 2021
| @@ -1,6 +1,6 @@ | |||
| //! Integration tests for oximeter collectors and producers. | |||
|
|
|||
| mod common; | |||
| pub mod common; | |||
There was a problem hiding this comment.
The reason for this change is similar to what's described in rust-lang/rust#46379: some tests that use mod common use identity_eq function, but this one doesn't. So when Cargo builds this test, it reports a dead_code warning on identity_eq. Every other test file works around this kind of problem using pub mod common. Other solutions are possible (e.g., put identity_eq into a separate module that's only included where needed), but for now I'm doing the simple thing that's consistent with the other tests.
smklein
approved these changes
Sep 15, 2021
|
@smklein ditto! 😬 |
|
Thanks for the reviews! @jessfraz tells me to ignore the "403 Forbidden" error in the Docker build because it's a server error so I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change cleans up several warnings in the build.
This depends on #225. That one changes the toolchain, and so changes the warnings around.