linter: cannot disable no-nested-ternary rule anymore

[jeremy-dupre]

What version of Oxlint are you using?

0.15.6

What command did you run?

oxlint -c .oxlintrc.json src

What does your .oxlint.json config file look like?

{
"$schema": "./node_modules/oxlint/configuration_schema.json",
"env": {
"browser": true,
"es2024": true
},
"settings": {},
"plugins": ["oxc", "typescript", "unicorn"],
"categories": {
"correctness": "error",
"perf": "error",
"suspicious": "error",
"restriction": "error",
"style": "warn",
"pedantic": "warn",
"nursery": "off"
},
"rules": {
"no-nested-ternary": "off",
"eslint/no-nested-ternary": "off",
"unicorn/no-nested-ternary": "off"
}
}

What happened?

Since the new 'eslint/no-nested-ternary' rule appeared in 0.15.x (duplicating/replacing the previous unicorn/no-nested-ternary rule?), it seems it cannot be deactivated anymore. With the above setup the rule is still active and generates warning.
It was not the case in 0.14.x

[shulaoda]

Related to #5714

Should we change it?

oxc/crates/oxc_linter/src/config/config_builder.rs

Lines 242 to 243 in c15af02

	// NOTE: this logic means there's no way to disable ESLint
	// correctness rules. I think that's fine for now.

[1zumii]

@shulaoda
i found that eslint/no-nested-ternary rule is set as RuleCategory::Style

maybe not the filter condition caused this issue?

oxc/crates/oxc_linter/src/rules/eslint/no_nested_ternary.rs

Lines 41 to 43 in c15af02

	NoNestedTernary,
	eslint,
	style,

[shulaoda]

@shulaoda i found that eslint/no-nested-ternary rule is set as RuleCategory::Style

maybe not the filter condition caused this issue?

oxc/crates/oxc_linter/src/rules/eslint/no_nested_ternary.rs

Lines 41 to 43 in c15af02

 NoNestedTernary, 
 eslint, 
 style,

Yes, I made a mistake.

[1zumii]

i guess problem is in this branch, only remove one of these rules with same name.

result that unicorn's rule is removed, but eslint's rule still remains.

oxc/crates/oxc_linter/src/config/rules.rs

Lines 133 to 136 in c15af02

	} else if rule_configs.iter().all(|r| r.severity.is_allow()) {
	if let Some(rule) = rules_for_override.iter().find(|r| r.name() == *name) {
	rules_to_remove.push(rule.clone());
	}

[arnriu]

Have same problem. See my closed ticket 👆🏻 if you need to see my config and tests.

[joshderochervlk-simplisafe]

Hi, the fix for this works if I have the rule set to "off" for both, or one set to "error" and the other "off", but if I set one to "warn" and the other to "off" the one configured to "warn" shows up as an error.

// works
"eslint/no-nested-ternary": "off",
"unicorn/no-nested-ternary": "off"

// works
"eslint/no-nested-ternary": "error",
"unicorn/no-nested-ternary": "off"

// Shows an error for eslint(no-nested-ternary)
"eslint/no-nested-ternary": "warn",
"unicorn/no-nested-ternary": "off"

[shulaoda]

Hi, the fix for this works if I have the rule set to "off" for both, or one set to "error" and the other "off", but if I set one to "warn" and the other to "off" the one configured to "warn" shows up as an error.

// works
"eslint/no-nested-ternary": "off",
"unicorn/no-nested-ternary": "off"

// works
"eslint/no-nested-ternary": "error",
"unicorn/no-nested-ternary": "off"

// Shows an error for eslint(no-nested-ternary)
"eslint/no-nested-ternary": "warn",
"unicorn/no-nested-ternary": "off"

Hi, it has been fixed in #8840. We just need to wait for its release.