chore: cleanup.

Author: rzvxa

crates/oxc_ast/src/generated/span.rs

@@ -1,6 +1,8 @@
 // Auto-generated code, DO NOT EDIT DIRECTLY!
 // To edit this generated file you have to edit `tasks/ast_codegen/src/generators/impl_get_span.rs`
 
+#![allow(clippy::match_same_arms)]
+
 use crate::ast::*;
 use oxc_span::{GetSpan, Span};
 

tasks/ast_codegen/src/generators/impl_get_span.rs

@@ -1,7 +1,7 @@
 use itertools::Itertools;
 use proc_macro2::TokenStream;
 use quote::quote;
-use syn::Variant;
+use syn::{parse_quote, Attribute, Variant};
 
 use crate::{
     schema::{REnum, RStruct, RType},
@@ -33,8 +33,12 @@ impl Generator for ImplGetSpanGenerator {
 
         GeneratorOutput::One(quote! {
             #header
+            insert!("#![allow(clippy::match_same_arms)]");
+            endl!();
+
             use crate::ast::*;
             use oxc_span::{GetSpan, Span};
+
             #(#impls)*
         })
     }

tasks/ast_codegen/src/linker.rs

@@ -91,7 +91,7 @@ pub fn linker(ty: &mut RType, ctx: &CodegenCtx) -> Result<bool> {
             Inherit::Linked { .. } => Ok(it),
         })
         .collect::<Vec<std::result::Result<Inherit, Inherit>>>();
-    let unresolved = inherits.iter().any(|it| it.is_err());
+    let unresolved = inherits.iter().any(std::result::Result::is_err);
 
     ty.meta.inherits = inherits.into_iter().map(|it| it.unwrap_or_else(|it| it)).collect();
 

tasks/ast_codegen/src/main.rs

@@ -1,5 +1,5 @@
 // TODO: remove me please!
-#![allow(dead_code)]
+#![allow(dead_code, unused_imports)]
 mod defs;
 mod generators;
 mod linker;
@@ -55,31 +55,31 @@ enum GeneratorOutput {
 }
 
 impl GeneratorOutput {
-    pub fn as_none(self) {
-        match self {
-            Self::None => {}
-            _ => panic!(),
-        }
+    pub fn as_none(&self) {
+        assert!(matches!(self, Self::None));
     }
 
-    pub fn as_one(self) -> TokenStream {
-        match self {
-            Self::One(it) => it,
-            _ => panic!(),
+    pub fn as_one(&self) -> &TokenStream {
+        if let Self::One(it) = self {
+            it
+        } else {
+            panic!();
         }
     }
 
-    pub fn as_many(self) -> HashMap<String, TokenStream> {
-        match self {
-            Self::Many(it) => it,
-            _ => panic!(),
+    pub fn as_many(&self) -> &HashMap<String, TokenStream> {
+        if let Self::Many(it) = self {
+            it
+        } else {
+            panic!();
         }
     }
 
-    pub fn as_info(self) -> String {
-        match self {
-            Self::Info(it) => it,
-            _ => panic!(),
+    pub fn as_info(&self) -> &String {
+        if let Self::Info(it) = self {
+            it
+        } else {
+            panic!();
         }
     }
 }
@@ -186,7 +186,7 @@ fn output_dir() -> Result<String> {
 
 #[allow(clippy::print_stdout)]
 fn main() -> std::result::Result<(), Box<dyn std::error::Error>> {
-    let CodegenResult { schema, outputs } = files()
+    let CodegenResult { outputs, .. } = files()
         .fold(AstCodegen::default(), AstCodegen::add_file)
         .with(AstGenerator)
         .with(AstKindGenerator)
@@ -199,8 +199,8 @@ fn main() -> std::result::Result<(), Box<dyn std::error::Error>> {
 
     {
         let span_path = format!("{output_dir}/span.rs");
-        let mut span_file = fs::File::create(&span_path)?;
-        let output = outputs[ImplGetSpanGenerator.name()].clone().as_one();
+        let mut span_file = fs::File::create(span_path)?;
+        let output = outputs[ImplGetSpanGenerator.name()].as_one();
         let span_content = pprint(output);
 
         span_file.write_all(span_content.as_bytes())?;

tasks/ast_codegen/src/pprint.rs

@@ -27,10 +27,11 @@ impl Replacer for EndlReplacer {
     fn replace_append(&mut self, _: &Captures, _: &mut String) {}
 }
 
-pub fn pprint(input: TokenStream) -> String {
+pub fn pprint(input: &TokenStream) -> String {
     lazy_static! {
         static ref INSERT_REGEX: Regex = Regex::new(
-            format!(r#"(?m)^{INSERT_MACRO_IDENT}!\([\n\s\S]*?\"([\s\S]*?)\"[\n\s\S]*?\);$"#).as_str()
+            format!(r#"(?m)^{INSERT_MACRO_IDENT}!\([\n\s\S]*?\"([\s\S]*?)\"[\n\s\S]*?\);$"#)
+                .as_str()
         )
         .unwrap();
     };