Skip to content

Commit 8cce69a

Browse files
committed
refactor(codegen): remove match_member_expression (#8597)
1 parent ac4f98e commit 8cce69a

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

crates/oxc_codegen/src/gen.rs

+11-9
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ pub trait Gen: GetSpan {
1919
fn gen(&self, p: &mut Codegen, ctx: Context);
2020

2121
/// Generate code for an AST node. Alias for `gen`.
22+
#[inline]
2223
fn print(&self, p: &mut Codegen, ctx: Context) {
2324
self.gen(p, ctx);
2425
}
@@ -30,6 +31,7 @@ pub trait GenExpr: GetSpan {
3031
fn gen_expr(&self, p: &mut Codegen, precedence: Precedence, ctx: Context);
3132

3233
/// Generate code for an expression, respecting operator precedence. Alias for `gen_expr`.
34+
#[inline]
3335
fn print_expr(&self, p: &mut Codegen, precedence: Precedence, ctx: Context) {
3436
self.gen_expr(p, precedence, ctx);
3537
}
@@ -1186,9 +1188,9 @@ impl GenExpr for Expression<'_> {
11861188
Self::StringLiteral(lit) => lit.print(p, ctx),
11871189
Self::Identifier(ident) => ident.print(p, ctx),
11881190
Self::ThisExpression(expr) => expr.print(p, ctx),
1189-
match_member_expression!(Self) => {
1190-
self.to_member_expression().print_expr(p, precedence, ctx);
1191-
}
1191+
Self::ComputedMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
1192+
Self::StaticMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
1193+
Self::PrivateFieldExpression(expr) => expr.print_expr(p, precedence, ctx),
11921194
Self::CallExpression(expr) => expr.print_expr(p, precedence, ctx),
11931195
Self::ArrayExpression(expr) => expr.print(p, ctx),
11941196
Self::ObjectExpression(expr) => expr.print_expr(p, precedence, ctx),
@@ -1899,9 +1901,9 @@ impl GenExpr for SimpleAssignmentTarget<'_> {
18991901
fn gen_expr(&self, p: &mut Codegen, precedence: Precedence, ctx: Context) {
19001902
match self {
19011903
Self::AssignmentTargetIdentifier(ident) => ident.print(p, ctx),
1902-
match_member_expression!(Self) => {
1903-
self.to_member_expression().print_expr(p, precedence, ctx);
1904-
}
1904+
Self::ComputedMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
1905+
Self::StaticMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
1906+
Self::PrivateFieldExpression(expr) => expr.print_expr(p, precedence, ctx),
19051907
Self::TSAsExpression(e) => e.print_expr(p, precedence, ctx),
19061908
Self::TSSatisfiesExpression(e) => e.print_expr(p, precedence, ctx),
19071909
Self::TSNonNullExpression(e) => e.print_expr(p, precedence, ctx),
@@ -2174,9 +2176,9 @@ impl GenExpr for ChainExpression<'_> {
21742176
p.wrap(precedence >= Precedence::Postfix, |p| match &self.expression {
21752177
ChainElement::CallExpression(expr) => expr.print_expr(p, precedence, ctx),
21762178
ChainElement::TSNonNullExpression(expr) => expr.print_expr(p, precedence, ctx),
2177-
match_member_expression!(ChainElement) => {
2178-
self.expression.to_member_expression().print_expr(p, precedence, ctx);
2179-
}
2179+
ChainElement::ComputedMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
2180+
ChainElement::StaticMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
2181+
ChainElement::PrivateFieldExpression(expr) => expr.print_expr(p, precedence, ctx),
21802182
});
21812183
}
21822184
}

0 commit comments

Comments
 (0)