Skip to content

Commit 03ad1e3

Browse files
committed
refactor(semantic): tweak comment argument type (#4157)
Minor followup from #4132.
1 parent b632c04 commit 03ad1e3

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

crates/oxc_semantic/src/jsdoc/builder.rs

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use std::collections::BTreeMap;
22

3-
use oxc_ast::{AstKind, CommentKind, Trivias};
3+
use oxc_ast::{AstKind, Comment, Trivias};
44
use oxc_span::{GetSpan, Span};
55
use rustc_hash::FxHashSet;
66

@@ -32,7 +32,7 @@ impl<'a> JSDocBuilder<'a> {
3232
.trivias
3333
.comments()
3434
.filter(|comment| !self.leading_comments_seen.contains(&comment.span.start))
35-
.filter_map(|comment| self.parse_if_jsdoc_comment(comment.kind, comment.span))
35+
.filter_map(|comment| self.parse_if_jsdoc_comment(comment))
3636
.collect::<Vec<_>>();
3737

3838
JSDocFinder::new(self.attached_docs, not_attached_docs)
@@ -129,7 +129,7 @@ impl<'a> JSDocBuilder<'a> {
129129
}
130130

131131
self.leading_comments_seen.insert(comment.span.start);
132-
if let Some(jsdoc) = self.parse_if_jsdoc_comment(comment.kind, comment.span) {
132+
if let Some(jsdoc) = self.parse_if_jsdoc_comment(comment) {
133133
leading_jsdoc_comments.push(jsdoc);
134134
}
135135
}
@@ -144,20 +144,20 @@ impl<'a> JSDocBuilder<'a> {
144144
true
145145
}
146146

147-
fn parse_if_jsdoc_comment(&self, kind: CommentKind, comment_span: Span) -> Option<JSDoc<'a>> {
148-
if !kind.is_multi_line() {
147+
fn parse_if_jsdoc_comment(&self, comment: &Comment) -> Option<JSDoc<'a>> {
148+
if !comment.kind.is_multi_line() {
149149
return None;
150150
}
151151

152152
// Inside of marker: /*CONTENT*/ => CONTENT
153-
let comment_content = comment_span.source_text(self.source_text);
153+
let comment_content = comment.span.source_text(self.source_text);
154154
// Should start with "*"
155155
if !comment_content.starts_with('*') {
156156
return None;
157157
}
158158

159159
// Remove the very first `*`
160-
let jsdoc_span = Span::new(comment_span.start + 1, comment_span.end);
160+
let jsdoc_span = Span::new(comment.span.start + 1, comment.span.end);
161161
Some(JSDoc::new(&comment_content[1..], jsdoc_span))
162162
}
163163
}

0 commit comments

Comments
 (0)