Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data pages use indicator tag data when chart tag data is present #4532

Open
ikesau opened this issue Feb 5, 2025 · 0 comments
Open

Data pages use indicator tag data when chart tag data is present #4532

ikesau opened this issue Feb 5, 2025 · 0 comments

Comments

@ikesau
Copy link
Member

ikesau commented Feb 5, 2025

Problem

Slack context

In the living languages data page, no tags are shown, despite the chart being tagged with 2 tags in the admin.

Image

Image

This is due to the ETL indicator data tagging the indicator as "Uncategorized", which according to Lucas, is to indicate that the data managers aren't sure how to categorize the data.

I fixed the dangling heading showing up in the data page header, but the fix for this that properly reconciles the two sources of truth will take a bit more effort.

Impact

Presumably a number of data pages are missing tags, which has the effect of removes topic page links on the top right of the data pages, so slightly worse navigation.

Proposed solution

Probably the union of chart and indicator tags excluding Uncategorized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants