🎉 add data insights to algolia pages index #4541
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -105,15 +106,20 @@ async function generateWordpressRecords( | |||
| const getPostTypeAndImportance = ( | |||
There was a problem hiding this comment.
I wanted to rewrite the PageType type to use the OwidGdocType enum so that it would be compatible with getCanonicalUrl which we now need to be able to link to data insights correctly on the search page, so I had to refactor these 3 functions that each had a pattern match statement.
ikesau
force-pushed
the
data-insights-in-algolia
branch
from
e69cbaf to
1595b38
Compare
ikesau
force-pushed
the
data-insights-in-algolia
branch
from
1595b38 to
79c6628
Compare
ikesau
force-pushed
the
data-insights-in-algolia
branch
from
79c6628 to
dbf649b
Compare
|
@Marigold okay so yeah, it is just exceeding the timeout duration - indexing everything takes around 20 minutes now If/when we drop the ExplorerViews index (which is redundant now that we have ExplorerViewsAndCharts) we'll drop 6 minutes or so, but for now maybe the easiest thing is to increase the limit. |
|
Fair enough! I've increased the timeout to 60 mins (here it is if you want to further increase it). This will apply only to |
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-02-25 08:54:24 UTC |
|
Hey @mlbrgl - I'm requesting a review from you on this, but it's also an invitation to get it over the finish line this cooldown if you'd like 🙂 I've tagged Marwa in the P&D channel to make sure the design's okay |
Resolves #4507
Figma
Adds Data Insights as a supported gdoc type in the
indexPagesToAlgoliascript.Most of this PR's diff comes from updating the union type
PageTypeto use theOwidGdocTypeenum so that I could callgetCanonicalURLin the search panel (to correctly prefix the slug with/data-insights/)I also added a slightly complicated
getFirstBlockOfTypeimplementation because my first attempt at this change needed to get both the first image and first paragraph. It's less essential for the PR on the whole, now, but I think will still be a useful util to keep around.