-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support esbuild plugin onStart
, onEnd
, and onDispose
callbacks
#2771
Comments
I am creating an npm module that requires 'use client'; directive to remain at the top of the file after build. bun is stripping it out right now. It looks like esbuild is recommending the banner feature for equivalent functionality. I believe I could make a bun plugin to put 'use client' back this but need onEnd supported. Thank you for implementing when it makes sense. |
What's the status of this? |
|
I forgot to put it here, but I'm actively developing the onEnd hook. I can put up the branch if anyone else is interested in helping. |
Currently, we do not implement these three callbacks, but instead throw an error pointing to this issue.
They are very trivial to implement in a non-reloading setting, and mostly simple in a watch/hmr build. Usage is documented here.
Keep this issue open until:
onStart
onEnd
onDispose
resolve()
, prob open a separate issueThe text was updated successfully, but these errors were encountered: