Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a codecov token or revert fail_ci_if_error #2420

Closed
spencerschrock opened this issue Nov 2, 2022 · 1 comment · Fixed by #2422
Closed

Add a codecov token or revert fail_ci_if_error #2420

spencerschrock opened this issue Nov 2, 2022 · 1 comment · Fixed by #2422

Comments

@spencerschrock
Copy link
Member

Now that codecov fails CI, some rate limiting that was occurring before is now a blocker for some PRs. Adding a token to a public repo, though not required, helps with these rate limits.

- uses: codecov/codecov-action@v3
  with:
    token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos

See codecov/codecov-action#557 (comment) and comments more details.

The other alternative is reverting #2415

@spencerschrock
Copy link
Member Author

I'm leaning towards reverting, as the token isn't a perfect fix. The goal was to surface typos in codecov uploads, but seems to be doing more harm than good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant