This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Fix gzclient crash when deleting a model that's being manipulated #2856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash happens because the visual pointer in
ModelManipulator
is not reset when the model is being deleted.To reproduce:
gazebo --verbose
The fix is to reset the visual pointer when detaching the model. I also had to fix a material transparency issue that happens when I tried to insert the same model back into the world (after being deleted while dragging) and found that It always reverted to use old semi-transparent material. The workaround is to also reset the transparency before resetting the visual pointer.
Signed-off-by: Ian Chen ichen@osrfoundation.org