BLMODULES-29 - ensure correct casting for boolean strings in HQL

Author: jclausen

src/main/java/ortus/boxlang/modules/orm/HQLQuery.java

@@ -122,7 +122,7 @@ private List<QueryParameter> buildParameterList( Array positionalParameters, ISt
 		}
 
 		boolean			isPositional		= positionalParameters != null;
-		String			HQL					= this.hql;
+		String			HQL					= sanitizeHQL( this.hql );
 		// This is the HQL string with the named parameters replaced with positional placeholders
 		StringBuilder	newHQL				= new StringBuilder();
 		// This is the name of the current named parameter being processed
@@ -349,4 +349,17 @@ public Object execute() {
 		}
 
 	}
+
+	/**
+	 * Sanitize the HQL string to ensure that common strings are cast correctly
+	 *
+	 * @param hql
+	 *
+	 * @return
+	 */
+	private String sanitizeHQL( String hql ) {
+		return hql.replaceAll( "= true", "= cast( true as boolean )" )
+		    .replaceAll( "= false", "= cast( true as boolean )" );
+
+	}
 }

src/test/java/ortus/boxlang/modules/orm/bifs/ORMExecuteQueryTest.java

@@ -153,7 +153,6 @@ public void testHQLCollection() {
 	@Test
 	public void testHQLAdvancedMap() {
 		// @formatter:off
-		// TODO: We need to add support for a raw `WHERE isPublished = true` which currently throws a strict type error
 		instance.executeSource( """
 		results = ormExecuteQuery( "
 			SELECT new map(
@@ -162,10 +161,10 @@ SELECT new map(
 				MONTH( MAX( publishedDate ) ) as month
 			)
 			FROM cbEntry
-			WHERE isPublished = :isPublished
+			WHERE isPublished = true
 			AND passwordProtection = ''
 			AND publishedDate <= :now",
-			{ isPublished: true, now : now() }
+			{ now : now() }
 		);
 		result = results.map( ( entity ) => getMetadata( entity ).name );