Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload empty blob when packing #260

Closed
shizhMSFT opened this issue Aug 2, 2022 · 2 comments · Fixed by #262
Closed

Upload empty blob when packing #260

shizhMSFT opened this issue Aug 2, 2022 · 2 comments · Fixed by #262
Assignees
Milestone

Comments

@shizhMSFT
Copy link
Contributor

The current Pack() method packs a {} config blob for the target OCI manifest.

configBytes := []byte("{}")

When using OCI manifest as the medium of the artifact, the content of the config blob is unused. Therefore, it is better to have an empty blob instead of {}. That is,

{
  "digest": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
  "size": 0
}
@shizhMSFT shizhMSFT added this to the v2.0.0-rc.2 milestone Aug 2, 2022
@shizhMSFT
Copy link
Contributor Author

@m5i-work Could you take this item?

@m5i-work
Copy link
Contributor

m5i-work commented Aug 4, 2022

@shizhMSFT Let me take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants