Skip to content

Commit cb8c8bc

Browse files
authored
refactor: make credentials.NewMemoryStore return an interface (#605)
1. Un-expose `credentials.MemoryStore` as it is unecessary to be public 2. Make `credentials.NewMemoryStore` return an interface instead of a struct Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
1 parent 9f83e67 commit cb8c8bc

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

registry/remote/credentials/memory_store.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,18 @@ import (
2222
"oras.land/oras-go/v2/registry/remote/auth"
2323
)
2424

25-
// MemoryStore is a store that keeps credentials in memory.
26-
type MemoryStore struct {
25+
// memoryStore is a store that keeps credentials in memory.
26+
type memoryStore struct {
2727
store sync.Map
2828
}
2929

3030
// NewMemoryStore creates a new in-memory credentials store.
31-
func NewMemoryStore() *MemoryStore {
32-
return &MemoryStore{}
31+
func NewMemoryStore() Store {
32+
return &memoryStore{}
3333
}
3434

3535
// Get retrieves credentials from the store for the given server address.
36-
func (ms *MemoryStore) Get(_ context.Context, serverAddress string) (auth.Credential, error) {
36+
func (ms *memoryStore) Get(_ context.Context, serverAddress string) (auth.Credential, error) {
3737
cred, found := ms.store.Load(serverAddress)
3838
if !found {
3939
return auth.EmptyCredential, nil
@@ -42,13 +42,13 @@ func (ms *MemoryStore) Get(_ context.Context, serverAddress string) (auth.Creden
4242
}
4343

4444
// Put saves credentials into the store for the given server address.
45-
func (ms *MemoryStore) Put(_ context.Context, serverAddress string, cred auth.Credential) error {
45+
func (ms *memoryStore) Put(_ context.Context, serverAddress string, cred auth.Credential) error {
4646
ms.store.Store(serverAddress, cred)
4747
return nil
4848
}
4949

5050
// Delete removes credentials from the store for the given server address.
51-
func (ms *MemoryStore) Delete(_ context.Context, serverAddress string) error {
51+
func (ms *memoryStore) Delete(_ context.Context, serverAddress string) error {
5252
ms.store.Delete(serverAddress)
5353
return nil
5454
}

registry/remote/credentials/memory_store_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func TestMemoryStore_Get_notExistRecord(t *testing.T) {
4040

4141
func TestMemoryStore_Get_validRecord(t *testing.T) {
4242
ctx := context.Background()
43-
ms := NewMemoryStore()
43+
ms := NewMemoryStore().(*memoryStore)
4444

4545
serverAddress := "registry.example.com"
4646
want := auth.Credential{

0 commit comments

Comments
 (0)