internal/scaffold/crd.go: use structural schema for non-go operator CRDs #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
requested review from
jmrodri,
hasbro17,
camilamacedo86 and
estroz
openshift-ci-robot
added
the
size/M
| @@ -15,6 +15,7 @@ | |||
| package scaffold | |||
|
|
|||
| import ( | |||
| goerrors "errors" | |||
There was a problem hiding this comment.
why create an alias ? Could not it jus be :
Suggested change
| goerrors "errors" | |
| "errors" |
There was a problem hiding this comment.
We're already using github.com/pkg/errors in this file, so one of them needs an alias. Rather than changing all of the existing usages, I thought it would be simpler and easier to review to use an alias here.
camilamacedo86
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
/lgtm /approved
- Test changes locally
- The CRD was created with
$ cat deploy/crds/cache.example.com_memcacheds_crd.yaml
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
name: memcacheds.cache.example.com
spec:
group: cache.example.com
names:
kind: Memcached
listKind: MemcachedList
plural: memcacheds
singular: memcached
scope: Namespaced
subresources:
status: {}
validation:
openAPIV3Schema:
type: object
x-kubernetes-preserve-unknown-fields: true
versions:
- name: v1alpha1
served: true
- It was applied in the cluster with success as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR updates the CRD scaffolder for non-go projects to begin using valid structural schema.
Motivation for the change:
Structural schemas are required in v1 CRDs. This change will make it simpler for project maintainers and users to migrate from v1beta1 CRDs to v1 CRDs in the future.
Since ansible and helm v2 do not provide schemas for their roles, playbooks, and charts, and we have no way to easily derive them, we need to continue preserving all CR fields.