Skip to content

Commit f31d704

Browse files
committed
tests: Disable rate limiting for tests parsing flow dumps from logs.
A few tests are parsing ovs-vswitchd.log for flow dump debug logs. Those logs are rate limited and there is a chance required information will not end up in the file, especially on large systems, since amount of revalidator logs is proportional to the core count. Fix that by disabling rate limiting for dpif module in such tests. Fixes: c2a77f3 ("tests/ofproto-dpif: Use vlog to test dpif behaviour.") Reported-at: openvswitch/ovs-issues#361 Acked-by: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
1 parent 16848c9 commit f31d704

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

tests/dpif-netdev.at

+1
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,7 @@ m4_define([DPIF_NETDEV_MISS_FLOW_DUMP],
230230
AT_CHECK([ovs-appctl upcall/disable-ufid], [0], [Datapath dumping tersely using UFID disabled
231231
], [])
232232
AT_CHECK([ovs-appctl vlog/set dpif:dbg dpif_netdev:dbg])
233+
AT_CHECK([ovs-appctl vlog/disable-rate-limit dpif])
233234

234235
AT_CHECK([ovs-ofctl add-flow br0 action=normal])
235236
AT_CHECK([ovs-appctl netdev-dummy/receive p1 'in_port(1),packet_type(ns=0,id=0),eth(src=50:54:00:00:00:09,dst=50:54:00:00:00:0a),eth_type(0x0800),ipv4(src=10.0.0.2,dst=10.0.0.1,proto=1,tos=0,ttl=64,frag=no),icmp(type=8,code=0)'])

tests/ofproto-dpif.at

+2
Original file line numberDiff line numberDiff line change
@@ -9221,6 +9221,7 @@ AT_CHECK([ovs-appctl upcall/disable-ufid], [0], [Datapath dumping tersely using
92219221
], [])
92229222
AT_CHECK([ovs-appctl time/stop])
92239223
AT_CHECK([ovs-appctl vlog/set dpif:dbg dpif_netdev:dbg])
9224+
AT_CHECK([ovs-appctl vlog/disable-rate-limit dpif])
92249225

92259226
AT_CHECK([ovs-ofctl add-flow br0 actions=LOCAL,output:1,output:2])
92269227
AT_CHECK([ovs-ofctl add-flow br1 actions=LOCAL,output:1,output:3])
@@ -9936,6 +9937,7 @@ m4_define([OFPROTO_DPIF_MEGAFLOW_DISABLED],
99369937
[AT_SETUP([ofproto-dpif megaflow - disabled$1])
99379938
OVS_VSWITCHD_START([], [], [], [m4_if([$1], [], [], [--dummy-numa="0,0,0,0,1,1,1,1"])])
99389939
AT_CHECK([ovs-appctl vlog/set dpif:dbg dpif_netdev:dbg])
9940+
AT_CHECK([ovs-appctl vlog/disable-rate-limit dpif])
99399941
func=`printf '%s_' "$1" | cut -c 4-`
99409942
add_${func}of_ports br0 1 2
99419943
AT_DATA([flows.txt], [dnl

0 commit comments

Comments
 (0)