Skip to content

Sync doesn't work in Vivaldi #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eight04 opened this issue Feb 15, 2021 · 5 comments · Fixed by #1186
Closed

Sync doesn't work in Vivaldi #1182

eight04 opened this issue Feb 15, 2021 · 5 comments · Fixed by #1186

Comments

@eight04
Copy link
Collaborator

eight04 commented Feb 15, 2021

  • Browser: Vivaldi 3.4.2066.106 (Stable channel) (64-bit)
  • Operating System: Arch Linux (everything is bleeding edge)
  • Stylus Version: Any version using webext-launch-web-auth-flow

https://forum.vivaldi.net/topic/55513/does-not-trigger-onbeforerequest-for-popups

So the workaround for Vivaldi would be to use type: 'normal', I guess.

First we have to make webext-launch-web-auth-flow accept a mode: "popup" | "tab" option.

@eight04 eight04 changed the title Can Sync doesn't work in Vivaldi Feb 15, 2021
@narcolepticinsomniac
Copy link
Member

Should this be on the agenda as something which needs to be addressed before pushing a bug fix update, or is it getting back-burnered for being yet another Vivaldi self-inflicted bug?

@narcolepticinsomniac
Copy link
Member

@eight04 Unless you say otherwise sometime this weekend, I'm gonna assume this is not a priority for the next release.

@eight04
Copy link
Collaborator Author

eight04 commented Feb 21, 2021

I'm not able to work on it these days. However it shouldn't be hard to implement. webext-launch-web-auth-flow@0.1.1 supports two new options alwaysUseTab and windowOptions. We just have to configure them in token-manager.js.

@exterm
Copy link

exterm commented Aug 5, 2022

Just installed stylus on Vivaldi, tried to enable sync and got the same error. The auth flow was opened in a popup.

@tophf
Copy link
Member

tophf commented Aug 5, 2022

@Mottie, time to publish the beta? BTW now there are two zip files: stylus-chrome.zip and stylus-firefox.zip.

@exterm, the fix isn't released yet, but you can install development version of Stylus from the repository zip on chrome://extensions page in the browser: enable the "developer mode" switch then drop the file on the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants