-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new disclosure behavior breaking fill area drop down #5743
Comments
I think the reason the second time it works is because of what we set _expanded to here I guess on reload |
well darn, as one reads code they see that the feature I suggested is already implemented! ...so i guess the real question is, can we add true for default expanded... |
@maxgrossman Thanks for finding this! I fixed it by calling the appropriate This gives me another idea: we could avoid running |
@quincylvania - you rule! such a quick fix. to your point - sounds like a good idea. |
@maxgrossman Thanks! I implemented the check for most of the sections in 1323ec3. |
🚤 |
I noticed that the fill area drop down intermittently does not open anything when I click it.
I did some investigation and the issue seems to have to do with a recent change to the
uiDisclosure
class.What seems to be happening is that the above line is what is responsible for responsible for calling the renderFillList function that turns
_fillList
from null to a selection of the area fill unordered list.In the cases when this function is not called, the
drawListItems
function is given an empty selection and so it never executes its intended rendering.Would adding some sort of additional param to the disclosure class to force that the disclosure to be called in certain cases achieve fixing this bug and keep @bhousel's recent change?
I'm thinking it could make that disclosure line something like...
where force expand is a new parameter to the class and only in select cases like the the one above do we ever provided the value true.
The text was updated successfully, but these errors were encountered: