Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Values in "Source" Field Dropdown #10787

Closed
draunger opened this issue Feb 18, 2025 · 3 comments · Fixed by #10799
Closed

Duplicate Values in "Source" Field Dropdown #10787

draunger opened this issue Feb 18, 2025 · 3 comments · Fixed by #10799
Labels
bug A bug - let's fix this! field An issue with a field in the user interface

Comments

@draunger
Copy link
Contributor

draunger commented Feb 18, 2025

URL

No response

How to reproduce the issue?

Description:

When uploading changes in iD Editor, the "Source" field dropdown shows duplicate values, and some entries have inconsistent text formatting and colors. This creates confusion for users selecting a source for their changes.

Steps to Reproduce:

  • Open iD Editor and make any changes to the map.
  • Click on the upload button to prepare the changeset.
  • Open the "Sources" dropdown.
  • Observe that some values appear twice (e.g., "Local Knowledge" and "local knowledge"), and some have different colors and text formatting.

Expected Behavior:

Each source option should appear only once.
Text formatting should be consistent (e.g., same casing and color for similar values).

Screenshot(s) or anything else?

Image

Which deployed environments do you see the issue in?

No response

What version numbers does this issue effect?

2.32.0

Which browsers are you seeing this problem on?

Chrome

@tyrasd
Copy link
Member

tyrasd commented Feb 18, 2025

Text formatting should be consistent (e.g., same casing and color for similar values).

No, that's intended: the blue options are defined in the id-tagging-schema repo (here) and are translated to different languages, while the black ones are other other raw untranslated values of the tag that are either typed in by the user manually or fetched from taginfo, see service/taginfo.js.

That said, it is actually wrong that there are two options for local knowledge… it could be related to #10764 perhaps //cc @k-yle

PS: @draunger please fill out the version number of iD where you've experienced the bug.

@tyrasd tyrasd changed the title Duplicate and Inconsistent Values in "Source" Field Dropdown Duplicate Values in "Source" Field Dropdown Feb 18, 2025
@tyrasd tyrasd added bug A bug - let's fix this! field An issue with a field in the user interface labels Feb 18, 2025
@draunger
Copy link
Contributor Author

@tyrasd so at the end i have to remove the duplicate values from the dropdown am i right or something else ?

@tyrasd
Copy link
Member

tyrasd commented Feb 18, 2025

let's give @k-yle a chance to give this a look, as he's the one who has last changed this field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! field An issue with a field in the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants