Boresha Afya Fixes: Saving a Family takes more than 5mins

[samkanga]

APK - Kituoni (Health Facility)
Android version 7

Steps to reproduce:
a) Click add family
b) Fill in the fields
c) Click Submit

See attached video

20220701_102536.mp4

.

[owais-vd]

processClient method is synchronized in CoreClientProcessor class.

https://github.com/opensrp/opensrp-client-chw-core/blob/0ad08cde606d7759bb29f6b04852859f6ef28a58/opensrp-chw-core/src/main/java/org/smartregister/chw/core/sync/CoreClientProcessor.java#L125

and initially when we launch the app the processClient method is blocked by thread IntentService[SyncClientEventsPerTaskIntentService].

cc: @samkanga

[owais-vd]

a suggestion here, can we remove synchronized keyword from the processClient method so other threads cannot block it.
cc: @ekigamba

[hilpitome]

@owais-vd we can do that but there could be repercussions. The main question would be, why was the synchronized modifier added in the first place. I have traced it to this commit by @raihan-mpower. It would be a good place to start. cc @samkanga

[ekigamba]

I agree with @hilpitome.

I'd prefer we leave it as-is, unless there's a better alternative and good reason to remove it given that it relates to synchronizing multiple-threads.

@owais-vd Are there other performance improvements that you can suggest or identified causes for slowness?

Follow this documentation that will help you investigate further and implement previous fixes:

Here is a checklist

• Updates to the latest core libraries to fix issues
• Make sure the event-client tables and other details tables have the base-entity-id index. Some migrations that required recreating these tables did not recreate the indexes.
• Investigate illegal operations on the app by running the app with StrictMode enabled
• Check for memory leaks using Leak Canary
• Check for long-running queries, disable or optimize them
• Check for long-running operations on the main thread
• Disable report generation running and make it ad-hoc

Other performance-related discussions for reference and perusal:

• https://github.com/opensrp/support/issues/122
• Child Health v.0.2.17 performance tests issues opensrp-client-giz-malawi#254

cc @samkanga

[faith-mutua]

@samkanga @owais-vd the issue has been resolved. Saving a family now takes less than a minute