Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.16] Ensure ContainerHealthy condition is set back to True (#15712) #1171

Merged

Conversation

skonto
Copy link

@skonto skonto commented Feb 6, 2025

Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Matthias Diester <matthias.diester@de.ibm.com>
@openshift-ci openshift-ci bot requested review from mvinkler and rhuss February 6, 2025 15:11
@openshift-ci openshift-ci bot added the approved label Feb 6, 2025
@skonto skonto requested review from dsimansk and removed request for rhuss and mvinkler February 6, 2025 15:11
@dsimansk
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 11, 2025
Copy link

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link

/override ?

Copy link

openshift-ci bot commented Feb 11, 2025

@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • Konflux kflux-prd-rh02 / kn-serving-test-pizzaplanetv1-116-on-pull-request
  • Konflux kflux-prd-rh02 / kn-serving-test-readiness-116-on-pull-request
  • Update deps
  • ci/prow/417-images
  • ci/prow/417-test-e2e
  • ci/prow/417-test-e2e-tls
  • pull-ci-openshift-knative-serving-release-next-417-images
  • pull-ci-openshift-knative-serving-release-next-417-test-e2e
  • pull-ci-openshift-knative-serving-release-v1.15-417-test-e2e-tls
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link

/override "Konflux kflux-prd-rh02 / kn-serving-test-pizzaplanetv1-116-on-pull-request"
/override "Konflux kflux-prd-rh02 / kn-serving-test-readiness-116-on-pull-request"

Copy link

openshift-ci bot commented Feb 11, 2025

@dsimansk: Overrode contexts on behalf of dsimansk: Konflux kflux-prd-rh02 / kn-serving-test-pizzaplanetv1-116-on-pull-request, Konflux kflux-prd-rh02 / kn-serving-test-readiness-116-on-pull-request

In response to this:

/override "Konflux kflux-prd-rh02 / kn-serving-test-pizzaplanetv1-116-on-pull-request"
/override "Konflux kflux-prd-rh02 / kn-serving-test-readiness-116-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 79aca8b and 2 for PR HEAD 7ba9425 in total

@openshift-merge-bot openshift-merge-bot bot merged commit ec918b0 into openshift-knative:release-v1.16 Feb 11, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants