8273071: SeparatorSkin: must remove child on dispose

Reviewed-by: arapte

Author: Jeanette Winzenburg

modules/javafx.controls/src/main/java/javafx/scene/control/skin/SeparatorSkin.java

@@ -26,15 +26,11 @@
 package javafx.scene.control.skin;
 
 import javafx.geometry.Orientation;
-import javafx.scene.Node;
-import javafx.scene.control.Accordion;
 import javafx.scene.control.Control;
 import javafx.scene.control.Separator;
 import javafx.scene.control.SkinBase;
 import javafx.scene.layout.Region;
 
-import java.util.Collections;
-
 /**
  * Default skin implementation for the {@link Separator} control.
  *
@@ -109,6 +105,13 @@ public SeparatorSkin(Separator control) {
      *                                                                         *
      **************************************************************************/
 
+
+    @Override
+    public void dispose() {
+        getChildren().remove(line);
+        super.dispose();
+    }
+
     /**
      * We only need to deal with the single "line" child region. The important
      * thing here is that we want a horizontal separator to have a line which is

modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinMemoryLeakTest.java

@@ -54,7 +54,6 @@
 import javafx.scene.control.PasswordField;
 import javafx.scene.control.ScrollBar;
 import javafx.scene.control.ScrollPane;
-import javafx.scene.control.Separator;
 import javafx.scene.control.Skin;
 import javafx.scene.control.Spinner;
 import javafx.scene.control.SplitMenuButton;
@@ -141,8 +140,6 @@ public static Collection<Object[]> data() {
                 PasswordField.class,
                 ScrollBar.class,
                 ScrollPane.class,
-                // @Ignore("8273071")
-                Separator.class,
                 // @Ignore("8245145")
                 Spinner.class,
                 SplitMenuButton.class,