8345142: Remove uses of SecurityManager in Printing related classes

Reviewed-by: azvegint, psadhukhan

Author: prrace

src/java.desktop/share/classes/java/awt/print/PrinterJob.java

@@ -64,11 +64,6 @@ public abstract class PrinterJob {
      * @return a new {@code PrinterJob}.
      */
     public static PrinterJob getPrinterJob() {
-        @SuppressWarnings("removal")
-        SecurityManager security = System.getSecurityManager();
-        if (security != null) {
-            security.checkPrintJobAccess();
-        }
         return sun.print.PlatformPrinterJobProxy.getPrinterJob();
     }
 

src/java.desktop/share/classes/javax/print/PrintServiceLookup.java

@@ -393,16 +393,7 @@ private static ArrayList<PrintService> getServices(DocFlavor flavor,
         /*
          * add any directly registered services
          */
-        ArrayList<PrintService> registeredServices = null;
-        try {
-          @SuppressWarnings("removal")
-          SecurityManager security = System.getSecurityManager();
-          if (security != null) {
-            security.checkPrintJobAccess();
-          }
-          registeredServices = getRegisteredServices();
-        } catch (SecurityException se) {
-        }
+        ArrayList<PrintService> registeredServices = getRegisteredServices();
         if (registeredServices != null) {
             PrintService[] services = registeredServices.toArray(
                            new PrintService[registeredServices.size()]);
@@ -458,16 +449,7 @@ private static ArrayList<MultiDocPrintService> getMultiDocServices(DocFlavor[] f
         /*
          * add any directly registered services
          */
-        ArrayList<PrintService> registeredServices = null;
-        try {
-          @SuppressWarnings("removal")
-          SecurityManager security = System.getSecurityManager();
-          if (security != null) {
-            security.checkPrintJobAccess();
-          }
-          registeredServices = getRegisteredServices();
-        } catch (Exception e) {
-        }
+        ArrayList<PrintService> registeredServices = getRegisteredServices();
         if (registeredServices != null) {
             PrintService[] services =
                 registeredServices.toArray(new PrintService[registeredServices.size()]);

src/java.desktop/share/classes/javax/print/ServiceUI.java

@@ -203,10 +203,7 @@ public static PrintService printDialog(GraphicsConfiguration gc,
                                                  flavor, attributes,
                                                  owner);
         if (setOnTop) {
-            try {
-                dialog.setAlwaysOnTop(true);
-            } catch (SecurityException e) {
-            }
+            dialog.setAlwaysOnTop(true);
         }
         Rectangle dlgBounds = dialog.getBounds();
 

src/java.desktop/share/classes/sun/print/PSStreamPrintJob.java

@@ -434,12 +434,7 @@ public void pageableJob(Pageable pageable,
         }
 
         /* add the user name to the job */
-        String userName = "";
-        try {
-          userName = System.getProperty("user.name");
-        } catch (SecurityException se) {
-        }
-
+        String userName = System.getProperty("user.name");
         if (userName == null || userName.isEmpty()) {
             RequestingUserName ruName =
                 (RequestingUserName)reqSet.get(RequestingUserName.class);

src/java.desktop/share/classes/sun/print/PrintJob2D.java

@@ -310,12 +310,6 @@ private void initPrintJob2D(Frame frame,  String doctitle,
                                 JobAttributes jobAttributes,
                                 PageAttributes pageAttributes) {
 
-        @SuppressWarnings("removal")
-        SecurityManager security = System.getSecurityManager();
-        if (security != null) {
-            security.checkPrintJobAccess();
-        }
-
         if (frame == null &&
             (jobAttributes == null ||
              jobAttributes.getDialog() == DialogType.NATIVE)) {
@@ -366,11 +360,6 @@ private void initPrintJob2D(Frame frame,  String doctitle,
                 } catch (IOException ioe) {
                     throw new IllegalArgumentException("Cannot write to file:"+
                                                        destStr);
-                } catch (SecurityException se) {
-                    //There is already file read/write access so at this point
-                    // only delete access is denied.  Just ignore it because in
-                    // most cases the file created in createNewFile gets overwritten
-                    // anyway.
                 }
 
                  File pFile = f.getParentFile();
@@ -676,29 +665,18 @@ private void copyAttributes(PrintService printServ) {
                 attributes.add(defaultDest);
             } else {
                 URI uri = null;
-                try {
-                    if (fileName != null) {
-                        if (fileName.isEmpty()) {
-                            fileName = ".";
-                        }
-                    } else {
-                        // defaultDest should not be null.  The following code
-                        // is only added to safeguard against a possible
-                        // buggy implementation of a PrintService having a
-                        // null default Destination.
-                        fileName = "out.prn";
-                    }
-                    uri = (new File(fileName)).toURI();
-                } catch (SecurityException se) {
-                    try {
-                        // '\\' file separator is illegal character in opaque
-                        // part and causes URISyntaxException, so we replace
-                        // it with '/'
-                        fileName = fileName.replace('\\', '/');
-                        uri = new URI("file:"+fileName);
-                    } catch (URISyntaxException e) {
+                if (fileName != null) {
+                    if (fileName.isEmpty()) {
+                        fileName = ".";
                     }
+                } else {
+                    // defaultDest should not be null.  The following code
+                    // is only added to safeguard against a possible
+                    // buggy implementation of a PrintService having a
+                    // null default Destination.
+                    fileName = "out.prn";
                 }
+                uri = (new File(fileName)).toURI();
                 if (uri != null) {
                     attributes.add(new Destination(uri));
                 }

src/java.desktop/share/classes/sun/print/RasterPrinterJob.java

@@ -816,10 +816,7 @@ public PageFormat pageDialog(final PrintRequestAttributeSet attributes)
                                            DocFlavor.SERVICE_FORMATTED.PAGEABLE,
                                            attributes, w);
         if (setOnTop) {
-            try {
-                pageDialog.setAlwaysOnTop(true);
-            } catch (SecurityException e) {
-            }
+            pageDialog.setAlwaysOnTop(true);
         }
 
         Rectangle dlgBounds = pageDialog.getBounds();
@@ -948,15 +945,6 @@ public boolean printDialog(final PrintRequestAttributeSet attributes)
 
         }
 
-        /* A security check has already been performed in the
-         * java.awt.print.printerJob.getPrinterJob method.
-         * So by the time we get here, it is OK for the current thread
-         * to print either to a file (from a Dialog we control!) or
-         * to a chosen printer.
-         *
-         * We raise privilege when we put up the dialog, to avoid
-         * the "warning applet window" banner.
-         */
         GraphicsConfiguration grCfg = null;
         Window w = KeyboardFocusManager.getCurrentKeyboardFocusManager().getActiveWindow();
         if (w != null) {
@@ -1311,11 +1299,7 @@ protected  void setAttributes(PrintRequestAttributeSet attributes)
             (!fidelity && userName != null)) {
             userNameAttr = userName.getValue();
         } else {
-            try {
-                userNameAttr = getUserName();
-            } catch (SecurityException e) {
-                userNameAttr = "";
-            }
+            userNameAttr = getUserName();
         }
 
         /* OpenBook is used internally only when app uses Printable.
@@ -1654,11 +1638,6 @@ protected void validateDestination(String dest) throws PrinterException {
         } catch (IOException ioe) {
             throw new PrinterException("Cannot write to file:"+
                                        dest);
-        } catch (SecurityException se) {
-            //There is already file read/write access so at this point
-            // only delete access is denied.  Just ignore it because in
-            // most cases the file created in createNewFile gets overwritten
-            // anyway.
         }
 
         File pFile = f.getParentFile();
@@ -1818,7 +1797,6 @@ protected int getCopiesInt() {
 
     /**
      * Get the name of the printing user.
-     * The caller must have security permission to read system properties.
      */
     public String getUserName() {
         return System.getProperty("user.name");
@@ -1831,11 +1809,7 @@ protected String getUserNameInt() {
         if  (userNameAttr != null) {
             return userNameAttr;
         } else {
-            try {
-                return  getUserName();
-            } catch (SecurityException e) {
-                return "";
-            }
+            return getUserName();
         }
     }
 

src/java.desktop/share/classes/sun/print/ServiceDialog.java

@@ -169,10 +169,7 @@ void initPrintDialog(int x, int y,
              * on top property
              */
             if ((getOwner() == null) || (owner.getOwner() != getOwner())) {
-                try {
-                    setAlwaysOnTop(true);
-                } catch (SecurityException e) {
-                }
+                setAlwaysOnTop(true);
             }
         }
         Container c = getContentPane();
@@ -255,10 +252,7 @@ void initPageDialog(int x, int y,
             /* See comments in same block in initPrintDialog */
             DialogOwner owner = (DialogOwner)attributes.get(DialogOwner.class);
             if ((getOwner() == null) || (owner.getOwner() != getOwner())) {
-                try {
-                    setAlwaysOnTop(true);
-                } catch (SecurityException e) {
-                }
+                setAlwaysOnTop(true);
             }
         }
 
@@ -2937,13 +2931,7 @@ public void setSelected(boolean selected) {
     private static class ValidatingFileChooser extends JFileChooser {
         public void approveSelection() {
             File selected = getSelectedFile();
-            boolean exists;
-
-            try {
-                exists = selected.exists();
-            } catch (SecurityException e) {
-                exists = false;
-            }
+            boolean exists = selected.exists();
 
             if (exists) {
                 int val;
@@ -2966,11 +2954,6 @@ public void approveSelection() {
                                    getMsg("dialog.owtitle"),
                                    JOptionPane.WARNING_MESSAGE);
                 return;
-            } catch (SecurityException se) {
-                //There is already file read/write access so at this point
-                // only delete access is denied.  Just ignore it because in
-                // most cases the file created in createNewFile gets
-                // overwritten anyway.
             }
             File pFile = selected.getParentFile();
             if ((selected.exists() &&

src/java.desktop/share/classes/sun/print/ServiceNotifier.java

@@ -55,12 +55,9 @@ class ServiceNotifier extends Thread {
         super(null, null, service.getName() + " notifier", 0, false);
         this.service = service;
         listeners = new Vector<>();
-        try {
-              setPriority(Thread.NORM_PRIORITY-1);
-              setDaemon(true);
-              start();
-        } catch (SecurityException e) {
-        }
+        setPriority(Thread.NORM_PRIORITY-1);
+        setDaemon(true);
+        start();
     }
 
     void addListener(PrintServiceAttributeListener listener) {
@@ -93,10 +90,7 @@ void stopNotifier() {
      * immediate notification of listeners.
      */
     void wake() {
-        try {
-            interrupt();
-        } catch (SecurityException e) {
-        }
+        interrupt();
     }
 
    /* A heuristic is used to calculate sleep time.

src/java.desktop/unix/classes/sun/print/IPPPrintService.java

@@ -511,11 +511,6 @@ private void initAttributes() {
 
 
     public DocPrintJob createPrintJob() {
-        @SuppressWarnings("removal")
-        SecurityManager security = System.getSecurityManager();
-        if (security != null) {
-            security.checkPrintJobAccess();
-        }
         // REMIND: create IPPPrintJob
         return new UnixPrintJob(this);
     }
@@ -587,15 +582,7 @@ public DocPrintJob createPrintJob() {
             if (flavor == null ||
                 flavor.equals(DocFlavor.SERVICE_FORMATTED.PAGEABLE) ||
                 flavor.equals(DocFlavor.SERVICE_FORMATTED.PRINTABLE)) {
-                try {
                     return new Destination((new File("out.ps")).toURI());
-                } catch (SecurityException se) {
-                    try {
-                        return new Destination(new URI("file:out.ps"));
-                    } catch (URISyntaxException e) {
-                        return null;
-                    }
-                }
             }
             return null;
         } else if (category == Fidelity.class) {
@@ -797,11 +784,7 @@ public DocPrintJob createPrintJob() {
                 return null;
             }
         } else if (category == RequestingUserName.class) {
-            String userName = "";
-            try {
-              userName = System.getProperty("user.name", "");
-            } catch (SecurityException se) {
-            }
+            String userName = System.getProperty("user.name", "");
             return new RequestingUserName(userName, null);
         } else if (category == Sides.class) {
             // The printer takes care of Sides so if short-edge
@@ -1574,15 +1557,7 @@ public boolean isAttributeValueSupported(Attribute attr,
         } else if (category == Chromaticity.class) {
             return Chromaticity.COLOR;
         } else if (category == Destination.class) {
-            try {
-                return new Destination((new File("out.ps")).toURI());
-            } catch (SecurityException se) {
-                try {
-                    return new Destination(new URI("file:out.ps"));
-                } catch (URISyntaxException e) {
-                    return null;
-                }
-            }
+            return new Destination((new File("out.ps")).toURI());
         } else if (category == Fidelity.class) {
             return Fidelity.FIDELITY_FALSE;
         } else if (category == Finishings.class) {
@@ -1674,11 +1649,7 @@ public boolean isAttributeValueSupported(Attribute attr,
                 return new PageRanges(1, Integer.MAX_VALUE);
             }
         } else if (category == RequestingUserName.class) {
-            String userName = "";
-            try {
-              userName = System.getProperty("user.name", "");
-            } catch (SecurityException se) {
-            }
+            String userName = System.getProperty("user.name", "");
             return new RequestingUserName(userName, null);
         } else if (category == SheetCollate.class) {
             return SheetCollate.UNCOLLATED;