fix: "NutriScore V2" SVGs with blank space #11218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11218 +/- ##
=======================================
Coverage 49.18% 49.18%
=======================================
Files 78 78
Lines 22389 22389
Branches 5371 5371
=======================================
Hits 11011 11011
Misses 10020 10020
Partials 1358 1358 ☔ View full report in Codecov by Sentry. |
alexgarel
added a commit
that referenced
this pull request
Jan 10, 2025
🤖 I have created a release *beep* *boop* --- ## [2.54.0](v2.53.0...v2.54.0) (2025-01-10) ### Features * gzip js, css, SVG icons assets ([#11208](#11208)) ([c0a5275](c0a5275)) ### Bug Fixes * "NutriScore V2" SVGs with blank space ([#11218](#11218)) ([38d79e8](38d79e8)) * avoid crash in display_orgs_table when org.created_t is not set, fix permission ([#11203](#11203)) ([765d796](765d796)) * greenscore attribute with old ecoscore_data ([#11212](#11212)) ([4f596ad](4f596ad)) * Invalid OFF dark icon ([#11206](#11206)) ([f63daa8](f63daa8)) * Nutripatrol url trailing slash removal regex ([#11204](#11204)) ([f42f8dd](f42f8dd)) * Nutriscore for fresh herbs ([#11112](#11112)) ([cdd7cf5](cdd7cf5)) * Remove irrelevant things in Config_obf.pm ([c5d448d](c5d448d)) * Remove irrelevant things in the Open Beauty Facts config ([#11195](#11195)) ([c5d448d](c5d448d)) * remove warning in Display.pm related to Environmental Scoring ([#11172](#11172)) ([176fe9e](176fe9e)) * Removing irrelevant fields in the Open Products Facts config ([4583ed2](4583ed2)) * Removing irrelevant fields in the Open Products Facts config ([#11202](#11202)) ([4583ed2](4583ed2)) * typo in ecoscore redirect ([#11213](#11213)) ([85fd575](85fd575)) * use ecoscore data when greenscore not available ([#11197](#11197)) ([5ae1273](5ae1273)) * warnings in producers tests ([#11190](#11190)) ([0588976](0588976)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Alex Garel <alex@openfoodfacts.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
On some Nutri-score V2 SVG files, there is a blank space:
Without this fix, we have this weird layout in the mobile app: