Skip to content

Commit dc43c71

Browse files
committed
fix: correct flag value type in delete, import, and write
Fixes #387
1 parent 34fa32f commit dc43c71

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

cmd/store/import.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -245,8 +245,8 @@ var importCmd = &cobra.Command{
245245
func init() {
246246
importCmd.Flags().String("file", "", "File Name. The file should have the store")
247247
importCmd.Flags().String("store-id", "", "Store ID")
248-
importCmd.Flags().Int("max-tuples-per-write", tuple.MaxTuplesPerWrite, "Max tuples per write chunk.")
249-
importCmd.Flags().Int("max-parallel-requests", tuple.MaxParallelRequests, "Max number of requests to issue to the server in parallel.") //nolint:lll
248+
importCmd.Flags().Int32("max-tuples-per-write", tuple.MaxTuplesPerWrite, "Max tuples per write chunk.")
249+
importCmd.Flags().Int32("max-parallel-requests", tuple.MaxParallelRequests, "Max number of requests to issue to the server in parallel.") //nolint:lll
250250

251251
if err := importCmd.MarkFlagRequired("file"); err != nil {
252252
fmt.Printf("error setting flag as required - %v: %v\n", "cmd/models/write", err)

cmd/tuple/delete.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ var deleteCmd = &cobra.Command{
9999
func init() {
100100
deleteCmd.Flags().String("file", "", "Tuples file")
101101
deleteCmd.Flags().String("model-id", "", "Model ID")
102-
deleteCmd.Flags().Int("max-tuples-per-write", MaxTuplesPerWrite, "Max tuples per write chunk.")
103-
deleteCmd.Flags().Int("max-parallel-requests", MaxParallelRequests, "Max number of requests to issue to the server in parallel.") //nolint:lll
102+
deleteCmd.Flags().Int32("max-tuples-per-write", MaxTuplesPerWrite, "Max tuples per write chunk.")
103+
deleteCmd.Flags().Int32("max-parallel-requests", MaxParallelRequests, "Max number of requests to issue to the server in parallel.") //nolint:lll
104104
}
105105

106106
func ExactArgsOrFlag(n int, flag string) cobra.PositionalArgs {

cmd/tuple/import.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ import (
3232
)
3333

3434
// MaxTuplesPerWrite Limit the tuples in a single batch.
35-
var MaxTuplesPerWrite = 1
35+
var MaxTuplesPerWrite = int32(1)
3636

3737
// MaxParallelRequests Limit the parallel writes to the API.
38-
var MaxParallelRequests = 10
38+
var MaxParallelRequests = int32(10) //nolint:mnd
3939

4040
type failedWriteResponse struct {
4141
TupleKey client.ClientTupleKey `json:"tuple_key"`
@@ -206,6 +206,6 @@ var importCmd = &cobra.Command{
206206
func init() {
207207
importCmd.Flags().String("model-id", "", "Model ID")
208208
importCmd.Flags().String("file", "", "Tuples file")
209-
importCmd.Flags().Int("max-tuples-per-write", MaxTuplesPerWrite, "Max tuples per write chunk.")
210-
importCmd.Flags().Int("max-parallel-requests", MaxParallelRequests, "Max number of requests to issue to the server in parallel.") //nolint:lll
209+
importCmd.Flags().Int32("max-tuples-per-write", MaxTuplesPerWrite, "Max tuples per write chunk.")
210+
importCmd.Flags().Int32("max-parallel-requests", MaxParallelRequests, "Max number of requests to issue to the server in parallel.") //nolint:lll
211211
}

cmd/tuple/write.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,6 @@ func init() {
150150
writeCmd.Flags().String("file", "", "Tuples file")
151151
writeCmd.Flags().String("condition-name", "", "Condition Name")
152152
writeCmd.Flags().String("condition-context", "", "Condition Context (as a JSON string)")
153-
writeCmd.Flags().Int("max-tuples-per-write", MaxTuplesPerWrite, "Max tuples per write chunk.")
154-
writeCmd.Flags().Int("max-parallel-requests", MaxParallelRequests, "Max number of requests to issue to the server in parallel.")
153+
writeCmd.Flags().Int32("max-tuples-per-write", MaxTuplesPerWrite, "Max tuples per write chunk.")
154+
writeCmd.Flags().Int32("max-parallel-requests", MaxParallelRequests, "Max number of requests to issue to the server in parallel.")
155155
}

0 commit comments

Comments
 (0)