Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[json-tests] run all tests (or justify why not) #11085

Closed
dvdplm opened this issue Sep 23, 2019 · 0 comments · Fixed by #11597
Closed

[json-tests] run all tests (or justify why not) #11085

dvdplm opened this issue Sep 23, 2019 · 0 comments · Fixed by #11597
Assignees
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. F4-tests 💻 Tests need fixing, improving or augmenting. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.

Comments

@dvdplm
Copy link
Collaborator

dvdplm commented Sep 23, 2019

The json tests from https://github.com/ethereum/tests are organized in folders. We use the decl_test! macro to slurp up all the test files and build rust tests out of them. It is possible that we do not have a decl_test! for all folders. If that is so, add the missing test folders with a decl_macro! or figure out why a certain folder is not relevant to us.

Bonus points for figuring out a way to build the tests that does not require us to manually maintain a list of test file folders.

@dvdplm dvdplm added F4-tests 💻 Tests need fixing, improving or augmenting. P5-sometimesoon 🌲 Issue is worth doing soon. F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. labels Sep 23, 2019
@adria0 adria0 mentioned this issue Apr 22, 2020
6 tasks
@adria0 adria0 linked a pull request Apr 28, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. F4-tests 💻 Tests need fixing, improving or augmenting. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants