From 3e712651b0d519be2db9bacdfa0f01f779f451ab Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Thu, 22 Sep 2022 11:06:02 -0400 Subject: [PATCH] test!: Don't validate salesforce orgs against orgs.yml BREAKING CHANGE: We no longer test that the "Account Name" for the CSV has a valid entry in the orgs.yaml file in the same directory. This doesn't make sense because salesforce is now the source of truth so also needing we can trust it to have valid orgs. And if it doesn't that should be fixed in the salesforce process and not here. --- CHANGELOG.rst | 10 ++++++++++ repo_tools_data_schema/repo_tools_data_schema.py | 4 ---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index a06c6b1..204af93 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -9,6 +9,16 @@ Change Log This project adheres to Semantic Versioning (https://semver.org/). +2022-09-22 +~~~~~~~~~~ + +Changed +======= + +* Don't validate orgs using orgs.yaml in the saleseforce export csv. + + + 2020-08-07 ~~~~~~~~~~ diff --git a/repo_tools_data_schema/repo_tools_data_schema.py b/repo_tools_data_schema/repo_tools_data_schema.py index 8866ab6..2a9d839 100644 --- a/repo_tools_data_schema/repo_tools_data_schema.py +++ b/repo_tools_data_schema/repo_tools_data_schema.py @@ -274,10 +274,6 @@ def validate_salesforce_export(filename, encoding="cp1252"): if acct == "Opfocus Test": # A bogus entry made by the vendor. skip it. continue - # "Individual Contributors" and "Household Accounts" are both Salesforce artifacts. - # In both cases, these records represent unaffiliated individual contributors. - acct_valid = (acct in ALL_ORGS or acct == "Individual Contributors" or acct.endswith(" Household")) - assert acct_valid, f"Account Name is not a valid org: {acct}" username = row["GitHub Username"] assert github_username(username), f"GitHub Username is not valid: {username}"