chore(bors): merge pull request #592

592: feat(helm chart): add value to modify ps retries r=Abhinandan-Purkait a=Abhinandan-Purkait

- Adds a helm value to modify the io-engine `ps-retries`.

Co-authored-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>

Author: mayastor-bors

chart/README.md

@@ -176,6 +176,7 @@ This removes all the Kubernetes components associated with the chart and deletes
 | io_engine.​nvme.​ioTimeout | Timeout for IOs The default here is exaggerated for local disks, but we've observed that in shared virtual environments having a higher timeout value is beneficial. Please adjust this according to your hardware and needs. | `"110s"` |
 | io_engine.​nvme.​tcp.​maxQueueDepth | You may need to increase this for a higher outstanding IOs per volume | `"32"` |
 | io_engine.​priorityClassName | Set PriorityClass, overrides global | `""` |
+| io_engine.​pstorRetries | Number of retries for pstor persistence before the volume target self shutdowns | `300` |
 | io_engine.​resources.​limits.​cpu | Cpu limits for the io-engine | `""` |
 | io_engine.​resources.​limits.​hugepages2Mi | Hugepage size available on the nodes | `"2Gi"` |
 | io_engine.​resources.​limits.​memory | Memory limits for the io-engine | `"1Gi"` |

chart/templates/mayastor/io/io-engine-daemonset.yaml

@@ -111,6 +111,7 @@ spec:
         - "--reactor-freeze-detection"{{ end }}
         - "--tgt-crdt={{ .Values.io_engine.target.nvmf.hostCmdRetryDelay.crdt1 }}"{{ if .Values.eventing.enabled }}
         - "--events-url=nats://{{ .Release.Name }}-nats:4222"{{ end }}
+        - "--ps-retries={{ default 300 .Values.io_engine.pstorRetries }}"
         command:
         - io-engine
         securityContext:

chart/values.yaml

@@ -466,6 +466,8 @@ io_engine:
   priorityClassName: ""
   # -- Runtime class to use. Defaults to cluster standard
   runtimeClassName: ""
+  # -- Number of retries for pstor persistence before the volume target self shutdowns
+  pstorRetries: 300
 
 etcd:
   # -- Disable when using an external etcd cluster.