Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested go.mod may not be suitable #314

Open
vbatts opened this issue Dec 9, 2021 · 1 comment
Open

nested go.mod may not be suitable #314

vbatts opened this issue Dec 9, 2021 · 1 comment

Comments

@vbatts
Copy link
Member

vbatts commented Dec 9, 2021

with #283 we landed ./specs-go/go.mod.

The motivation to put it nested was to avoid pulling in deps that have nothing to do with the bare structures of the spec.
But this model with modules is tricky. And even in the opencontainers/image-spec#883 we found it simpler to just have the top level go.mod, rather than messing with a git-tag workflow, etc.

One other point, is it seems some tools like gopls do not easily handle nested go.mod files 🤷 :
Screenshot from 2021-12-09 13-02-39

@BenTheElder
Copy link

go.work in 1.18 makes this easier while retaining the separate dependency sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants