Skip to content

Commit 127f256

Browse files
committed
Fix #60: Consolidate admon content model
* Force admons to have at least one para as first child * Allow informal{example,figure,table,equation} in admon content model (as suggested by Stefan) * Disallow formalpara as a first child in admonitions (to avoid layout issues) * Add test cases
1 parent d5b8894 commit 127f256

File tree

3 files changed

+56
-21
lines changed

3 files changed

+56
-21
lines changed

geekodoc/rng/geekodoc5-flat.rnc

+18-10
Original file line numberDiff line numberDiff line change
@@ -10514,16 +10514,24 @@ div {
1051410514
div {
1051510515
db.admonition.contentmodel =
1051610516
db._info.title.only,
10517-
db.remark*,
10518-
db.para,
10519-
(db.list.blocks
10520-
| db.formalpara
10521-
| db.verbatim.blocks
10522-
| db.remark
10523-
| db.para
10524-
| db.xi.include
10525-
| db.informalexample
10526-
| db.informalfigure)*
10517+
(db.remark*,
10518+
(db.para | db.xi.include),
10519+
(db.list.blocks
10520+
| db.informalexample
10521+
| db.informalfigure
10522+
| db.informaltable
10523+
| db.informalequation
10524+
| db.informal.blocks
10525+
| db.publishing.blocks
10526+
| db.graphic.blocks
10527+
| db.technical.blocks
10528+
| db.verbatim.blocks
10529+
| db.remark
10530+
| db.para
10531+
| db.formalpara
10532+
| db.simpara
10533+
| db.extension.blocks
10534+
| db.xi.include)*)
1052710535
db.admonition.blocks =
1052810536
# Removed caution
1052910537
db.important

geekodoc/rng/geekodoc5.rnc

+16-11
Original file line numberDiff line numberDiff line change
@@ -1177,17 +1177,22 @@ include "docbookxi.rnc"
11771177
div {
11781178
db.admonition.contentmodel =
11791179
db._info.title.only,
1180-
db.remark*,
1181-
db.para,
1182-
(db.list.blocks
1183-
| db.formalpara
1184-
| db.verbatim.blocks
1185-
| db.remark
1186-
| db.para
1187-
| db.xi.include
1188-
| db.informalexample
1189-
| db.informalfigure
1190-
)*
1180+
(db.remark*,
1181+
(db.para | db.xi.include),
1182+
(db.list.blocks
1183+
| db.informalexample
1184+
| db.informalfigure
1185+
| db.informaltable
1186+
| db.informalequation
1187+
| db.informal.blocks
1188+
| db.publishing.blocks
1189+
| db.graphic.blocks
1190+
| db.technical.blocks
1191+
| db.verbatim.blocks
1192+
| db.remark
1193+
| db.para | db.formalpara | db.simpara
1194+
| db.extension.blocks
1195+
| db.xi.include)*)
11911196

11921197
db.admonition.blocks =
11931198
# Removed caution

geekodoc/tests/good/article-admons.xml renamed to geekodoc/tests/good/article-admonitions.xml

+22
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,26 @@
4141
<warning>
4242
<para>bla</para>
4343
</warning>
44+
<tip>
45+
<remark/>
46+
<para/>
47+
<screen/>
48+
<informalexample><screen/></informalexample>
49+
<informalfigure>
50+
<mediaobject>
51+
<textobject>
52+
<phrase/>
53+
</textobject>
54+
</mediaobject>
55+
</informalfigure>
56+
<informaltable>
57+
<tgroup cols="1">
58+
<tbody>
59+
<row>
60+
<entry/>
61+
</row>
62+
</tbody>
63+
</tgroup>
64+
</informaltable>
65+
</tip>
4466
</article>

0 commit comments

Comments
 (0)