fix: move getEnv into function for proper initialization (#309)

Author: Sittymin

server/src/services/favicon.ts

@@ -5,20 +5,24 @@ import { setup } from "../setup";
 import { createS3Client } from "../utils/s3";
 import path from "path";
 
-const env = getEnv();
 // @see https://developers.cloudflare.com/images/url-format#supported-formats-and-limitations
 export const FAVICON_ALLOWED_TYPES: { [key: string]: string } = {
     "image/jpeg": ".jpg",
     "image/png": ".png",
     "image/gif": ".gif",
     "image/webp": ".webp",
 };
-export const faviconKey = path.join(env.S3_FOLDER || "", "favicon.webp");
+export function getFaviconKey() {
+    const env = getEnv();
+    return path.join(env.S3_FOLDER || "", "favicon.webp");
+}
 
 export function FaviconService() {
+    const env = getEnv();
     const s3 = createS3Client();
     const bucket = env.S3_BUCKET;
     const accessHost = env.S3_ACCESS_HOST || env.S3_ENDPOINT;
+    const faviconKey = getFaviconKey();
     return new Elysia({ aot: false })
         .use(setup())
         .get("/favicon", async ({ set }) => {

server/src/services/rss.ts

@@ -2,7 +2,7 @@ import { PutObjectCommand } from "@aws-sdk/client-s3";
 import { and, desc, eq } from "drizzle-orm";
 import { drizzle } from "drizzle-orm/d1";
 import Elysia from "elysia";
-import { FAVICON_ALLOWED_TYPES, faviconKey } from "./favicon";
+import { FAVICON_ALLOWED_TYPES, getFaviconKey } from "./favicon";
 import { Feed } from "feed";
 import path from 'path';
 import rehypeStringify from "rehype-stringify";
@@ -62,6 +62,7 @@ export async function rssCrontab(env: Env) {
     const frontendUrl = `${env.FRONTEND_URL.startsWith("http://") || env.FRONTEND_URL.startsWith("https://") ? "" : "https://"}${env.FRONTEND_URL}`;
     const db = drizzle(env.DB, { schema: schema });
     const accessHost = env.S3_ACCESS_HOST || env.S3_ENDPOINT;
+    const faviconKey = getFaviconKey();
 
     let feedConfig: any = {
         title: env.RSS_TITLE,