Skip to content

Commit 2a5fe23

Browse files
MadVikingGodpellared
andauthoredNov 6, 2023
otelgrpc: Refine tests to use a net socket instead of a buffer (#4503)
Co-authored-by: Robert Pająk <pellared@hotmail.com>
1 parent 4c540e0 commit 2a5fe23

File tree

2 files changed

+145
-43
lines changed

2 files changed

+145
-43
lines changed
 

‎instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_stats_handler_test.go

+7-2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222
"github.com/stretchr/testify/require"
2323
"google.golang.org/grpc"
2424
"google.golang.org/grpc/codes"
25+
"google.golang.org/grpc/test/bufconn"
2526

2627
"go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc"
2728
"go.opentelemetry.io/otel/attribute"
@@ -46,14 +47,18 @@ func TestStatsHandler(t *testing.T) {
4647
serverMetricReader := metric.NewManualReader()
4748
serverMP := metric.NewMeterProvider(metric.WithReader(serverMetricReader))
4849

49-
assert.NoError(t, doCalls(
50+
listener := bufconn.Listen(bufSize)
51+
defer listener.Close()
52+
err := newGrpcTest(
53+
listener,
5054
[]grpc.DialOption{
5155
grpc.WithStatsHandler(otelgrpc.NewClientHandler(otelgrpc.WithTracerProvider(clientTP), otelgrpc.WithMeterProvider(clientMP))),
5256
},
5357
[]grpc.ServerOption{
5458
grpc.StatsHandler(otelgrpc.NewServerHandler(otelgrpc.WithTracerProvider(serverTP), otelgrpc.WithMeterProvider(serverMP))),
5559
},
56-
))
60+
)
61+
require.NoError(t, err)
5762

5863
t.Run("ClientSpans", func(t *testing.T) {
5964
checkClientSpans(t, clientSR.Ended())

0 commit comments

Comments
 (0)
Please sign in to comment.