Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

feat: improve performance when generating highlight card image #60

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

brandonroberts
Copy link
Contributor

Description

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Improves time taken to generate highlight card by doing requests in parallel and removing unnecessary requests
  • Time decreased from 4 seconds to under 1 second
  • With improved performance, the image can be returned directly instead of checking/uploading to S3
  • Also adds API_BASE_URL to use in development vs production deployments
  • Highlight cards can now be developed and tested locally through the browser http://localhost:3005/v1/highlights/115

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@brandonroberts brandonroberts changed the title fix: improve performance when generating highlight card image feat: improve performance when generating highlight card image Jul 12, 2023
@brandonroberts brandonroberts force-pushed the fix-highlight-card-perf branch from a1c1fbb to bf27de6 Compare July 12, 2023 18:09
@brandonroberts brandonroberts merged commit 2c94638 into beta Jul 12, 2023
@brandonroberts brandonroberts deleted the fix-highlight-card-perf branch July 12, 2023 18:13
github-actions bot pushed a commit that referenced this pull request Jul 12, 2023
## [2.3.0-beta.1](v2.2.1...v2.3.0-beta.1) (2023-07-12)

### πŸ• Features

* improve performance when generating highlight card image ([#60](#60)) ([2c94638](2c94638))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 2.3.0-beta.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jul 17, 2023
## [2.3.0](v2.2.1...v2.3.0) (2023-07-17)

### πŸ• Features

* improve performance when generating highlight card image ([#60](#60)) ([2c94638](2c94638))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 2.3.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant