login: smoother wifi dialog (fixes #5387) #5394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppp15
approved these changes
Feb 28, 2025
Okuro3499
requested changes
Mar 3, 2025
Comment on lines
91
to
98
| d.getButton(AlertDialog.BUTTON_POSITIVE)?.apply { | ||
| textSize = 14f | ||
| setPadding(20,20,20,20) | ||
| } | ||
| d.getButton(AlertDialog.BUTTON_NEGATIVE)?.apply { | ||
| textSize = 14f | ||
| setPadding(20,20,20,20) | ||
| } |
There was a problem hiding this comment.
val pd = AlertDialog.Builder(context, R.style.CustomAlertDialog) if you update this line to val pd = AlertDialog.Builder(context, R.style.AlertDialogTheme) where you change the dialog theme you won't need this line
pavi38
approved these changes
Mar 3, 2025
Okuro3499
requested changes
Mar 3, 2025
| var message = "" | ||
| if (NetworkUtils.isBluetoothEnabled()) message += "Bluetooth/" | ||
| if (NetworkUtils.isWifiEnabled()) message += "WiFi/" | ||
| message = message.trim().removeSuffix("/") |
There was a problem hiding this comment.
@huitk this works but why are we adding the / then removing it?
There was a problem hiding this comment.
I remove only the last "/" because if only Wifi is on, it will show WIfi/ instead if wifi. Or if both wifi and Bluetooth are on, it will show Bluetooth/Wifi/.
There was a problem hiding this comment.
@huitk can it be and since we are sure both bluetooth and wifi are on
Okuro3499
approved these changes
Mar 7, 2025
Avinash-Codes
approved these changes
Mar 7, 2025
dogi
changed the title
dogi
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5387
To test:
On DialogUtils.kt
On LoginActivity.kt