-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reexport async_trait::async_trait
#74
Conversation
a85e878
to
70204b7
Compare
Signed-off-by: Raiki Tamura <tamaron1203@gmail.com>
70204b7
to
1a65f9d
Compare
Can someone rerun CI? |
async_trait::async_trait
async_trait::async_trait
Oh thank you. It complained about the title of this pr. |
It should be fixed now. |
Just one question: is it required to export that? I mean, is it technically required, or does it lead to a better design? |
I tried to impl FeatureProvider without Async-rust, a famous graphql implementation in Rust, for example, export async_trait in this line. |
Thanks for educating me! Now I totally understand it. |
This PR
To create a new provider using this library, we need to use the
#[async_trait]
macro to impl traits.Related Issues
Notes
Follow-up Tasks
none
How to test
none