feat: process flag evaluation options in client #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarrio
force-pushed
the
feat/process-flag-evaluation-options
branch
from
21cdc21 to
2325248
Compare
|
Signed off on commits |
Merged
tcarrio
force-pushed
the
feat/process-flag-evaluation-options
branch
from
27f0e32 to
2efb839
Compare
- performs validation of options as dictionary before pulling hooks and hints - introduces immutable dictionary extension of dict following naming from 3.12 release - documented "upgrade" process for MappingProxyType Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
- commonly stored in .venv as the initial dir to support Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
tcarrio
force-pushed
the
feat/process-flag-evaluation-options
branch
from
2efb839 to
6d86aa1
Compare
Signed-off-by: Tom Carrio <tom@carrio.dev>
|
This needs a small fix in the typing to resolve the build issues, but otherwise this is a compatible change that makes the hooks inputs actually immutable, so worthwhile to get this working again. |
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
…efile Signed-off-by: Tom Carrio <tom@carrio.dev>
tcarrio
force-pushed
the
feat/process-flag-evaluation-options
branch
from
0ed59b7 to
297c0c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 92.92% 92.64% -0.28%
==========================================
Files 18 19 +1
Lines 325 340 +15
==========================================
+ Hits 302 315 +13
- Misses 23 25 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
StackScribe
reviewed
Nov 23, 2022
StackScribe
reviewed
Nov 23, 2022
StackScribe
reviewed
Nov 23, 2022
Co-authored-by: Meg McRoberts <mmcroberts@cloudbees.com> Signed-off-by: Tom Carrio <tom@carrio.dev>
toddbaert
reviewed
Nov 24, 2022
beeme1mr
requested review from
toddbaert,
justinabrahms,
ajhelsby and
matthewelwell
toddbaert
approved these changes
Nov 29, 2022
Co-authored-by: Meg McRoberts <mmcroberts@cloudbees.com> Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Co-authored-by: Matthew Elwell <mjelwell89@gmail.com> Signed-off-by: Tom Carrio <tom@carrio.dev>
tcarrio
force-pushed
the
feat/process-flag-evaluation-options
branch
from
0d250c7 to
01d3214
Compare
Signed-off-by: Tom Carrio <tom@carrio.dev>
|
The last outstanding work for this review seems to be utilizing a different build tool besides Make. I created a separate issue to track that work. In the meantime would we prefer to remove Make until Poetry/pipenv/etc. is implemented or leave it to be replaced when that issue is taken on? |
matthewelwell
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Provides additional steps towards spec compliance.
Notes
Follow-up Tasks
Hooks are completely unused still, but I'm chunking out separate PRs of work.
How to test
Added unit tests where applicable (nothing exists yet for the client though)