Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement API-Level Events #131

Closed
3 tasks
jamescarr opened this issue Jun 28, 2023 · 1 comment · Fixed by #278
Closed
3 tasks

Implement API-Level Events #131

jamescarr opened this issue Jun 28, 2023 · 1 comment · Fixed by #278
Assignees
@federicobond

Comments

@jamescarr
Copy link
Contributor

There are no signals for various events that happen

This is optional as per the spec but useful for integrators.

Definition of done:

  • Event Handlers are registered via the global API
  • Events are emitted internally when they occur
  • associated tests
@toddbaert toddbaert mentioned this issue Jul 4, 2023
Closed
8 tasks
@toddbaert
Copy link
Member

There's nothing wrong with implementing the API-level events in isolation - but I would caution that doing so (separately from client events) could increase the chances that we have breaking changes in the client events implementation.

We should keep that in mind when we undertake this.

@toddbaert toddbaert mentioned this issue Feb 23, 2024
Closed
2 tasks
@federicobond federicobond linked a pull request Mar 9, 2024 that will close this issue
feat: implement provider events #278
Merged
2 tasks
@federicobond federicobond self-assigned this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@federicobond federicobond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement provider events federicobond/python-sdk
3 participants
@jamescarr @federicobond @toddbaert