Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate php 7 #59

Merged
merged 2 commits into from
Feb 12, 2023
Merged

feat: deprecate php 7 #59

merged 2 commits into from
Feb 12, 2023

Conversation

tcarrio
Copy link
Member

@tcarrio tcarrio commented Feb 10, 2023

This PR

  • deprecates PHP 7.4

Related Issues

Notes

Follow-up Tasks

How to test

Signed-off-by: Tom Carrio <tom@carrio.dev>

build: provide a devenv config

style: apply linting updates for providers

style: apply phpcbf fixes

build: disable root-level phpcbf commit hook until configured

style: apply linting fixes to Flagd provider

refactor: confirm to new provider interface

chore: ignore all composer.lock files

build!: target new version of open-feature/sdk

Signed-off-by: Tom Carrio <tom@carrio.dev>
@tcarrio tcarrio force-pushed the feat/deprecate-php-7 branch from c0940a7 to d94689b Compare February 10, 2023 05:10
@tcarrio
Copy link
Member Author

tcarrio commented Feb 10, 2023

Squashed and signed off all commits

@tcarrio
Copy link
Member Author

tcarrio commented Feb 10, 2023

Will require some more work on other packages before I can merge, but the core lib is updated now

Signed-off-by: Tom Carrio <tom@carrio.dev>
@tcarrio tcarrio force-pushed the feat/deprecate-php-7 branch from 7ca1658 to 688252a Compare February 12, 2023 03:18
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #59 (688252a) into main (c9760b4) will not change coverage.
The diff coverage is 81.81%.

@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   59.76%   59.76%           
=======================================
  Files          34       34           
  Lines         507      507           
=======================================
  Hits          303      303           
  Misses        204      204           
Impacted Files Coverage Δ
hooks/OpenTelemetry/src/TracerHelper.php 0.00% <0.00%> (ø)
...src/http/FlagdResponseResolutionDetailsAdapter.php 30.76% <0.00%> (ø)
providers/Flagd/src/FlagdProvider.php 38.46% <50.00%> (ø)
providers/CloudBees/src/CloudBeesProvider.php 75.92% <100.00%> (ø)
...CloudBees/src/transformers/IdentityTransformer.php 100.00% <100.00%> (ø)
providers/Flagd/src/config/Validator.php 94.11% <100.00%> (ø)
providers/Split/src/SplitProvider.php 81.39% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tcarrio tcarrio merged commit d028e6d into main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant