Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: spec v0.5.0 compliance #82

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

skyerus
Copy link
Contributor

@skyerus skyerus commented Sep 28, 2022

Signed-off-by: Skye Gill gill.skye95@gmail.com

@skyerus skyerus linked an issue Sep 28, 2022 that may be closed by this pull request
1 task
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #82 (a3306ee) into main (fc4b871) will decrease coverage by 4.70%.
The diff coverage is 53.12%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   80.14%   75.43%   -4.71%     
==========================================
  Files           6        7       +1     
  Lines         418      460      +42     
==========================================
+ Hits          335      347      +12     
- Misses         70      100      +30     
  Partials       13       13              
Impacted Files Coverage Δ
pkg/openfeature/resolution_error.go 14.28% <14.28%> (ø)
pkg/openfeature/client.go 78.52% <100.00%> (ø)
pkg/openfeature/noop_provider.go 100.00% <100.00%> (ø)
pkg/openfeature/provider.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@skyerus skyerus force-pushed the issue-81_spec-0.5.0 branch from a3306ee to 843a247 Compare September 29, 2022 13:57
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
@skyerus skyerus force-pushed the issue-81_spec-0.5.0 branch from 843a247 to 1dc06f0 Compare September 29, 2022 14:04
@skyerus skyerus merged commit 69b8f8e into open-feature:main Sep 29, 2022
@skyerus skyerus deleted the issue-81_spec-0.5.0 branch September 29, 2022 15:20
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the party, but LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SDK to be compliant with spec v0.5.0
5 participants