Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use correct term "domain" instead of name/clientName in code #305

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

warber
Copy link
Contributor

@warber warber commented Nov 25, 2024

This PR

This PR ensures consistent usage of the term "domain" throughout the codebase, replacing instances of "name," "clientName," and similar terms.

Signed-off-by: Bernd Warmuth <bernd.warmuth@dynatrace.com>
@warber warber marked this pull request as ready for review November 25, 2024 12:22
@warber warber requested a review from a team as a code owner November 25, 2024 12:22
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me - my only concern with any of this is that it might be breaking, but I can't see anything that's exposed publicly which is changing.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.86%. Comparing base (96d86ba) to head (85a2b68).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
openfeature/client.go 72.72% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   86.86%   86.86%           
=======================================
  Files          12       12           
  Lines        1370     1370           
=======================================
  Hits         1190     1190           
  Misses        156      156           
  Partials       24       24           
Flag Coverage Δ
e2e 86.86% <90.62%> (ø)
unit 86.86% <90.62%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toddbaert toddbaert merged commit 73c0e85 into open-feature:main Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants