Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change progress loggers to reduce logging overhead #5140

Closed
janezpodhostnik opened this issue Dec 13, 2023 · 2 comments
Closed

Change progress loggers to reduce logging overhead #5140

janezpodhostnik opened this issue Dec 13, 2023 · 2 comments
Assignees
Labels
Performance Stale Label used when marking an issue stale.

Comments

@janezpodhostnik
Copy link
Contributor

Problem Definition

This relates to PR #5122
To the comments made here https://github.com/onflow/flow-go/pull/5122/files/c26a38eec6564439df9a8934ffff8866f3e3380a#diff-c72a04018fbedd8cfe575b706f0f99a701ce6fea23869a328bbdad4bb8b801ad

The progress log locks on every call which might be expensive

Proposed Solution

The Progress log should be a Closer and should use channels to speed it up.

Definition of Done

  • Progress log does not lock on every call
@j1010001
Copy link
Member

Improvement of checkpointing, migration and node startup performance

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Jun 23, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Stale Label used when marking an issue stale.
Projects
None yet
Development

No branches or pull requests

2 participants