Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Mobile stuck in loading spinner when WalletConnect SignClient hangs #269

Closed
jribbink opened this issue Oct 3, 2024 · 0 comments · Fixed by #268
Closed

[BUG] Mobile stuck in loading spinner when WalletConnect SignClient hangs #269

jribbink opened this issue Oct 3, 2024 · 0 comments · Fixed by #268
Assignees
Labels
bug Something isn't working

Comments

@jribbink
Copy link
Contributor

jribbink commented Oct 3, 2024

Current Behavior

Currently, if WalletConnect SignClient hangs on initialization/requesting URI, it will cause Discovery to get stuck in a loading state on mobile. The most common scenario is that the projectId is invalid

Expected Behavior

Should not get stuck. Failure to initialize WalletConnect should not brick FCL Discovery. That being said, we do generally need to wait for WalletConnect, as pre-fetching URI is necessary for deep linking. Minimum solution is to add a timeout.

Steps To Reproduce

Try using FCL Discovery with bad WC project ID on mobile.

Environment

n/a

What are you currently working on that this is blocking?

No response

@jribbink jribbink self-assigned this Oct 3, 2024
@jribbink jribbink added the bug Something isn't working label Oct 3, 2024
@jribbink jribbink moved this to ✅ Done in 🌊 Flow 4D Oct 3, 2024
@jribbink jribbink closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant