From 07a5491ad9fdc0e154596d85f33a9250d159c0ba Mon Sep 17 00:00:00 2001 From: ga-reth Date: Tue, 25 Feb 2025 12:31:12 +0000 Subject: [PATCH 1/3] feat(sdk): biome git hook --- sdk/README.md | 14 ++++++++++---- sdk/package.json | 7 ++++++- sdk/pnpm-lock.yaml | 9 +++++++++ 3 files changed, 25 insertions(+), 5 deletions(-) diff --git a/sdk/README.md b/sdk/README.md index 29971ad87..95536ce0b 100644 --- a/sdk/README.md +++ b/sdk/README.md @@ -2,10 +2,16 @@ ## Overview -The Omni SDK is a TypeScript library for interfacing with Omni SolverNet. +The Omni SDK is a TypeScript library for interfacing with Omni SolverNet, your gateway to any transaction, on any chain. ## Roadmap -- [ ] Publish alpha package -- [ ] Consume SolverNet API -- [ ] Build package abstractions - `core` vs `react` +- [✅] Publish alpha package +- [✅] Consume SolverNet API +- [ ] Add unit tests +- [ ] Add e2e tests +- [ ] type improvements +- [ ] zod schema validation +- [ ] Write docs +- [ ] Build package abstractions - `core` and `react` +- [ ] Add examples \ No newline at end of file diff --git a/sdk/package.json b/sdk/package.json index cc42b1ecc..7c4e48b67 100644 --- a/sdk/package.json +++ b/sdk/package.json @@ -21,7 +21,8 @@ "build:esm": "tsc -p tsconfig.build.json", "build:types": "tsc -p tsconfig.build.json", "clean": "rm -rf dist tsconfig.tsbuildinfo", - "precommit": "biome check --write" + "check": "biome check --write", + "prepare": "pnpm simple-git-hooks" }, "files": [ "dist/**", @@ -32,6 +33,9 @@ "engines": { "node": ">=22.x" }, + "simple-git-hooks": { + "pre-commit": "cd $(git rev-parse --show-toplevel)/sdk && pnpm check" + }, "peerDependencies": { "@tanstack/react-query": "^5.64.2", "react": ">=18", @@ -41,6 +45,7 @@ "devDependencies": { "@biomejs/biome": "1.9.4", "@types/react": "^19.0.8", + "simple-git-hooks": "^2.11.1", "typescript": "5.7.2" }, "repository": { diff --git a/sdk/pnpm-lock.yaml b/sdk/pnpm-lock.yaml index f9cf239a4..261346383 100644 --- a/sdk/pnpm-lock.yaml +++ b/sdk/pnpm-lock.yaml @@ -27,6 +27,9 @@ importers: '@types/react': specifier: ^19.0.8 version: 19.0.8 + simple-git-hooks: + specifier: ^2.11.1 + version: 2.11.1 typescript: specifier: 5.7.2 version: 5.7.2 @@ -1101,6 +1104,10 @@ packages: resolution: {integrity: sha512-QMEp5B7cftE7APOjk5Y6xgrbWu+WkLVQwk8JNjZ8nKRciZaByEW6MubieAiToS7+dwvrjGhH8jRXz3MVd0AYqQ==} hasBin: true + simple-git-hooks@2.11.1: + resolution: {integrity: sha512-tgqwPUMDcNDhuf1Xf6KTUsyeqGdgKMhzaH4PAZZuzguOgTl5uuyeYe/8mWgAr6IBxB5V06uqEf6Dy37gIWDtDg==} + hasBin: true + socket.io-client@4.8.1: resolution: {integrity: sha512-hJVXfu3E28NmzGk8o1sHhN3om52tRvwYeidbj7xKy2eIIse5IoKX3USlS6Tqt3BHAtflLIkCQBkzVrEEfWUyYQ==} engines: {node: '>=10.0.0'} @@ -2903,6 +2910,8 @@ snapshots: inherits: 2.0.4 safe-buffer: 5.2.1 + simple-git-hooks@2.11.1: {} + socket.io-client@4.8.1(bufferutil@4.0.9)(utf-8-validate@5.0.10): dependencies: '@socket.io/component-emitter': 3.1.2 From 09b92f0dd2b88ef8f643042c2c8b29f623470a5c Mon Sep 17 00:00:00 2001 From: ga-reth Date: Tue, 25 Feb 2025 12:43:39 +0000 Subject: [PATCH 2/3] chore(sdk): tweak readme --- sdk/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/README.md b/sdk/README.md index 95536ce0b..3f3aa22a6 100644 --- a/sdk/README.md +++ b/sdk/README.md @@ -8,10 +8,10 @@ The Omni SDK is a TypeScript library for interfacing with Omni SolverNet, your g - [✅] Publish alpha package - [✅] Consume SolverNet API +- [ ] Type improvements - [ ] Add unit tests - [ ] Add e2e tests -- [ ] type improvements -- [ ] zod schema validation +- [ ] Zod schema validation - [ ] Write docs - [ ] Build package abstractions - `core` and `react` - [ ] Add examples \ No newline at end of file From 26ca2a3373dd0b4c743ccb5c4edf750b8e653515 Mon Sep 17 00:00:00 2001 From: ga-reth Date: Tue, 25 Feb 2025 14:02:33 +0000 Subject: [PATCH 3/3] chore(sdk): update existing sdk check and rm ghook --- .pre-commit/run_sdk_checks.sh | 30 +++++++++++++++++++----------- sdk/README.md | 4 ++-- sdk/package.json | 7 +------ sdk/pnpm-lock.yaml | 9 --------- 4 files changed, 22 insertions(+), 28 deletions(-) diff --git a/.pre-commit/run_sdk_checks.sh b/.pre-commit/run_sdk_checks.sh index 4cdea4f07..c3c5bd815 100755 --- a/.pre-commit/run_sdk_checks.sh +++ b/.pre-commit/run_sdk_checks.sh @@ -9,17 +9,25 @@ SDK_DIR="$SCRIPT_DIR/../sdk" # get changed TS files TS_FILES=$(git diff --cached --name-only --diff-filter=ACMR | grep "^sdk.*\.\(ts\|tsx\)$" || true) -if [ -n "$TS_FILES" ]; then - echo "Running SDK checks..." - cd "$SDK_DIR" +echo "Running SDK checks..." +cd "$SDK_DIR" - # clean + build - echo "Building SDK..." - pnpm build:clean +# clean + build +echo "Building SDK..." +pnpm build - # precommit checks (Biome) - echo "Running SDK checks..." - pnpm precommit +# precommit checks (Biome) +echo "Running SDK checks..." +pnpm check - echo "SDK checks completed..." -fi +# TODO enable after issues resolved +# CHECK_EXIT_CODE=$? + +# if [ $CHECK_EXIT_CODE -ne 0 ]; then +# echo "SDK check failed with $CHECK_EXIT_CODE" +# exit $CHECK_EXIT_CODE +# fi + +echo "SDK check completed..." + +exit 0 diff --git a/sdk/README.md b/sdk/README.md index 3f3aa22a6..e0366fc6c 100644 --- a/sdk/README.md +++ b/sdk/README.md @@ -13,5 +13,5 @@ The Omni SDK is a TypeScript library for interfacing with Omni SolverNet, your g - [ ] Add e2e tests - [ ] Zod schema validation - [ ] Write docs -- [ ] Build package abstractions - `core` and `react` -- [ ] Add examples \ No newline at end of file +- [ ] Build package abstractions - `core` and `react` +- [ ] Add examples diff --git a/sdk/package.json b/sdk/package.json index 7c4e48b67..9b6da09e4 100644 --- a/sdk/package.json +++ b/sdk/package.json @@ -21,8 +21,7 @@ "build:esm": "tsc -p tsconfig.build.json", "build:types": "tsc -p tsconfig.build.json", "clean": "rm -rf dist tsconfig.tsbuildinfo", - "check": "biome check --write", - "prepare": "pnpm simple-git-hooks" + "check": "biome check --write" }, "files": [ "dist/**", @@ -33,9 +32,6 @@ "engines": { "node": ">=22.x" }, - "simple-git-hooks": { - "pre-commit": "cd $(git rev-parse --show-toplevel)/sdk && pnpm check" - }, "peerDependencies": { "@tanstack/react-query": "^5.64.2", "react": ">=18", @@ -45,7 +41,6 @@ "devDependencies": { "@biomejs/biome": "1.9.4", "@types/react": "^19.0.8", - "simple-git-hooks": "^2.11.1", "typescript": "5.7.2" }, "repository": { diff --git a/sdk/pnpm-lock.yaml b/sdk/pnpm-lock.yaml index 261346383..f9cf239a4 100644 --- a/sdk/pnpm-lock.yaml +++ b/sdk/pnpm-lock.yaml @@ -27,9 +27,6 @@ importers: '@types/react': specifier: ^19.0.8 version: 19.0.8 - simple-git-hooks: - specifier: ^2.11.1 - version: 2.11.1 typescript: specifier: 5.7.2 version: 5.7.2 @@ -1104,10 +1101,6 @@ packages: resolution: {integrity: sha512-QMEp5B7cftE7APOjk5Y6xgrbWu+WkLVQwk8JNjZ8nKRciZaByEW6MubieAiToS7+dwvrjGhH8jRXz3MVd0AYqQ==} hasBin: true - simple-git-hooks@2.11.1: - resolution: {integrity: sha512-tgqwPUMDcNDhuf1Xf6KTUsyeqGdgKMhzaH4PAZZuzguOgTl5uuyeYe/8mWgAr6IBxB5V06uqEf6Dy37gIWDtDg==} - hasBin: true - socket.io-client@4.8.1: resolution: {integrity: sha512-hJVXfu3E28NmzGk8o1sHhN3om52tRvwYeidbj7xKy2eIIse5IoKX3USlS6Tqt3BHAtflLIkCQBkzVrEEfWUyYQ==} engines: {node: '>=10.0.0'} @@ -2910,8 +2903,6 @@ snapshots: inherits: 2.0.4 safe-buffer: 5.2.1 - simple-git-hooks@2.11.1: {} - socket.io-client@4.8.1(bufferutil@4.0.9)(utf-8-validate@5.0.10): dependencies: '@socket.io/component-emitter': 3.1.2