Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare SDK for distribution #3169

Open
ga-reth opened this issue Feb 25, 2025 · 0 comments
Open

Prepare SDK for distribution #3169

ga-reth opened this issue Feb 25, 2025 · 0 comments
Assignees
@ga-reth
Labels
sdk
Milestone
s1 - SolverNet Be...

Comments

@ga-reth
Copy link
Contributor

ga-reth commented Feb 25, 2025 •
edited
Loading

Problem to Solve

Before distributing we have some remaining tasks:

  • improve typings
  • handle errors correctly in useOrder as we do in useQuote
  • add docs/readme guide
  • test on omega

Proposed Solution

  • resolve the above
@ga-reth ga-reth added the sdk label Feb 25, 2025
@ga-reth ga-reth self-assigned this Feb 25, 2025
@ga-reth ga-reth mentioned this issue Feb 25, 2025
Merged
ga-reth added a commit that referenced this issue Feb 25, 2025
@ga-reth
feat(sdk): validation errors and narrow types (#3185)
b84022c 
- clean up logic by making it consistent with `useOrder`
- abstract validation logic into seperate hook for readability
- narrow validation result, for example:

<img width="317" alt="Screenshot 2025-02-25 at 18 32 06"
src="https://github.com/user-attachments/assets/1b2ab8b6-7ce0-4d06-911f-01d4a900dfb5"
/>

issue: #3169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ga-reth ga-reth

Labels
sdk
Projects
None yet
Milestone
s1 - SolverNet Beta with 10 protocols...
Development

No branches or pull requests
1 participant
@ga-reth